-
Notifications
You must be signed in to change notification settings - Fork 57
Search Block: Master PR #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Block: Master PR #3210
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…utenberg-mobile into add/search-block-main
…utenberg-mobile into add/search-block-main
|
Being new on the block 😏, I think the search block gets an invite to the "other block list", as suggested here. |
|
@AmandaRiu I attempted to test this branch within WPiOS via setting the |
|
Oh thank you @guarani for this information:
I had completely missed that. |
@dcalhoun I think it may have been because I hadn't added the search block to the supported blocks in gutenberg mobile as @guarani had pointed out in this comment.. I've added it now though so it should work 🤞 |
dcalhoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I tested this, with a focus on WordPress/gutenberg#30783, on an iPhone SE and Samsung Galaxy S20.
We'll just need to change the gutenberg ref to a merge commit before merging this work.
Related to #3073. Instead of creating a new PR for every PR reviewed in Gutenberg, Cameron and I thought it'd make more sense to just have a master PR for updating the gutenberg reference for testing but not merging until the Search block has been added to the
initial-html.jsor has breaking tests. This way this PR can act as a record of all the PRs and it will be easier to parse.This PR is now ready for merge once the last PR in the table below has been approved and merged
To test
Click the active Gutenberg PR in the table to view full test instructions.
PR submission checklist: