Separator Block: Add top/bottom margins via block support and modified BoxControl #30609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
This was referenced Apr 8, 2021
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
8ae61ea to
faa04c8
Compare
aaronrobertshaw
requested review from
ellatrix,
oandregal and
spacedmonkey
as code owners
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
89348c2 to
d27643d
Compare
7 tasks
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
faa04c8 to
c09835c
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
d27643d to
c3f44dd
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
c09835c to
2029c03
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
2029c03 to
0fe1917
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
c3f44dd to
10e6f60
Compare
7 tasks
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
0fe1917 to
dfe3ff8
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
10e6f60 to
e5db3b8
Compare
Contributor
Author
|
This has been rebased after the changes on trunk to padding.js and spacing-panel.js fixing custom CSS units. |
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
011895b to
badcb34
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
e5db3b8 to
496b99a
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
badcb34 to
07b49e7
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
496b99a to
09d30db
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
07b49e7 to
d8bf09e
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
09d30db to
92abe52
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
d8bf09e to
f976e9e
Compare
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
92abe52 to
40c82c9
Compare
aaronrobertshaw
force-pushed
the
add/margin-support-with-configurable-sides
branch
from
f976e9e to
a3c0200
Compare
Base automatically changed from
add/margin-support-with-configurable-sides
to
trunk
May 11, 2021 08:03
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
0f57553 to
6f56746
Compare
Contributor
Author
|
Rebased after recent updates to the margin support. |
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
6f56746 to
fe6032a
Compare
youknowriad
reviewed
May 26, 2021
| } } | ||
| /> | ||
| </View> | ||
| <SeparatorSettings { ...props } /> |
Contributor
There was a problem hiding this comment.
Any reason we need all these changes to the block's edit function. The idea of the block supports is to "automatically" add support without changes, what's preventing us from doing that?
Contributor
Author
There was a problem hiding this comment.
The hr element used for the separator presents a couple of problems in the editor, mainly the ability to select it and visualize the changes made to margins.
The original issues related to this block expressed a desire to control the "height" which really related to margins instead. If we don't have a true height for the separator it makes the separator rather hard to select by click on it with the mouse. Adding a wrapper around the hr allows the margins to expand within a clickable container drastically improving selection.
Earlier iterations on this included a resizable box so the user could drag to resize the separator. While it was decided the drag resizing overcomplicated the block, keeping the visualizer was still desirable. The visualizer couldn't be added within the hr so also benefits from being in the new wrapper element.
The additional changes to the application of the styles were to make the separator display as expected.
In terms of saving the margins, that works as per normal "automatic" block support. The frontend is still only a simple hr with top/bottom margins. The bulk of the other changes in this PR are to offer the same functionality in native for the separator block as it has on the web.
Contributor
There was a problem hiding this comment.
I see the challenges here, though the extra wrapper creates a diversion between the frontend and backend that we tried to illiminate in blocks over time because it makes styling the editor for themes very hard and create a lot of inconsistencies.
It's maybe fine for this particular block but would be good to have themers perspective. cc @scruffian @carolinan
The visualizer couldn't be added within the hr so also benefits from being in the new wrapper element.
I'm aware of this and it's the reason we removed the visualizer temporarily from other blocks like the "group" block. I think it's be good to have the visualizer work a bit differently to solve this (don't rely on a parent element but maybe a "ref"/popover)
Do you think these issues: visualizer and block selection are absolutely necessary in this PR or do you think we can iterate on them separately while still keeping the front-backend parity (maybe using alternative solutions like the proposal above)?
Contributor
Author
There was a problem hiding this comment.
Do you think these issues: visualizer and block selection are absolutely necessary in this PR or do you think we can iterate on them separately while still keeping the front-backend parity
The visualizer and easier block selection are not non-negotiable.
I've updated this PR to remove the visualizer and minimise changes. The majority of the updates are now related to Native and adding color and margin controls there. The PR has been rebased as well.
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
2 times, most recently
from
6c0c304 to
f116adf
Compare
7 tasks
aaronrobertshaw
force-pushed
the
add/separator-top-bottom-margins
branch
from
d98a0bf to
f4be82a
Compare
Contributor
Author
|
@mtias do you have any thoughts on whether we should proceed with this PR or close it for now? This has been through several evolutions to arrive at the current state. It no longer adds a visualizer for the margins, nor includes a resizable box to adjust the height/margins. It simply applies top and bottom margins to the Separator via block supports along with updating the native controls to manage margins there also. Given the most common approach to managing spacing between blocks appears to be adding a spacer block. Does it make sense to continue with this PR? Demos of Separator block in this PRWeb: Screen.Recording.2021-11-05.at.2.48.22.pm.mp4Native: Screen.Recording.2021-11-05.at.2.45.03.pm.mp4 |
Contributor
Author
|
Closing this PR as there is a general movement towards using block gap support or the spacer block over margins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows control of the separator block's top and bottom margin via the new margin support added in #30608. This in turn leverages changes made to the BoxControl in #30606 to allow configurable sides.
How has this been tested?
Manually.
Test Instructions - Web
spacing.customMarginTest Instructions - Native
Screenshots
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).