This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Blockbase: remove unneeded margin rules #4808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
force-pushed
the
blockbase-table-margin
branch
from
795c97c to
c2fd495
Compare
Contributor
Author
|
Skatepark's separators need a look and probably custom CSS, since the original styles that this PR removes was being overridden, but I think we can make it in a separate PR or we'd have to ponyfill Blockbase more specifically while we wait for WordPress/gutenberg#30609 or a similar alternative from Gutenberg. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes CSS that is no longer necessary after block gap was implemented. After gap was introduced, these rules were being overriden.
Check that the table and separator blocks look evenly separated from other blocks:
Same is happening for Post template block:
And with the columns block: