Fix toolbar alignment in widget block editor #31698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Widgets Screen
Contributor
|
There are still some unusual failures in the CI tests. @donnapep Would you be able to rebase the branch against the latest |
* Use JSON serialization * Move JSON to getAllBlocks * Add comment
#29573) * Block nodes: create useBlockRef for access to block node via ref * Try layout effect * Adjust useMergeRef to not depend on ref order * wip * Rewrite * Fix multi select * Revert useMergeRefs * Fix roving toolbar reset * Add inline docs
…#31209) * components: Remove G2 portal * components: Update popover to no longer use g2 * components: Update Card snapshots for popover
* Try: Toolbar gap. * Retry toolbar gap * Restore pointer-events with a more general selector * Update packages/block-editor/src/components/block-list/style.scss Co-authored-by: Mitchell Austin <[email protected]>
* Blocks: Introduce registerBlockTypeFromMetadata API * Add i18n schema for block.json * Docs: Update documentation for metadata and internationalization * Test: Add test for registerBlockTypeFromMetadata * Blocks: Translate metadata loaded from block.json * Make fields translatable * Docs: Add changelog entry * Add i18n support for variations read from block metadata
* components: Remove wp-g2 from scrollable * Update snapshot tests * Update popover tests for scrollover dependency * components: Update Card snapshots for scrollable
* In-between inserter: use usRefCallback, use showInsertionPoint * Fix nested block issue * Clean up * Make __unstableOptions optional * Make InsertionPoint a component again * Clean up * Rebase fixes
* components: Remove wp-g2 from form-group and control-label * Update snapshots
* components: Remove wp-g2 imports from elevation * components: Update elevation storybook to remove css prop * Fix compilation errors and remove a usage of the `config` helper * Update snapshot tests
* components: Remove wp-g2 from surface * Update snapshots
#31243) * components: Remove wp-g2 from flex, vstack, hstack, spinner and control-group * Update snapshot tests * Fix text highlighter test * Update snapshots again
* Add color block support to table block
* Release script: Update react-native-editor version to 1.51.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.51.1 * Release script: Update with changes from 'npm run core preios' * Updates relative block-support asset path * Update react-native-editor changelog Includes 1.51.1 changes, as well as changes from 1.51.0 that were overlooked and merged into `trunk` _after_ 1.51.0 had been tagged. Co-authored-by: Antonis Lilis <[email protected]>
donnapep
requested review from
TimothyBJacobs,
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
getdave,
guarani,
gziolo,
kevin940726,
mkaz,
mkevins,
mmtr,
nerrad,
noahtallen,
noisysocks,
ntwb,
oandregal,
spacedmonkey,
swissspidy and
tellthemachines
as code owners
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31021.
Don't apply the
has-parentCSS class to the toolbar if the__experimentalParentSelectorflag is set. This class was applying the left margin to the toolbar when a block was selected in the widget area.How has this been tested?
block-editor-block-contextual-toolbarelement has thehas-parentclass, and that the toolbar alignment is correct.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).