Include missing attributes when upgrading embed block #33235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
7 tasks
|
Size Change: +1.6 kB (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 7, 2021
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Tested and attributes are preserved when changing the embed source.
LGTM 🚢
Contributor
Author
Thanks for the review @Mamaduka! I'll update the |
Contributor
Author
|
ntsekouras
reviewed
Jul 7, 2021
ntsekouras
approved these changes
Jul 8, 2021
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Include missing attributes in upgraded embed block * Update block-library changelog * Use rest of attributes when upgrading embed block
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include the following attributes that were missing when an embed block is upgraded due to finding a more suitable block:
aligncaptionallowResponsiveHow has this been tested?
Embedbutton.Align left.Show more settings(if they're not already displayed).Resize for smaller devicesoption.Embedbutton.Align left).Resize for smaller devicesoption is preserved (the option should be unchecked).Screenshots
embed-block-missing-attributes-fix.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).