Skip to content

Include missing attributes when upgrading embed block #33235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 3 commits into from
Jul 8, 2021
Merged

Include missing attributes when upgrading embed block #33235

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b08d9d
Include missing attributes in upgraded embed block
fluiddot Jul 6, 2021
3709b66
Update block-library changelog
fluiddot Jul 7, 2021
f9c347f
Use rest of attributes when upgrading embed block
fluiddot Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use rest of attributes when upgrading embed block
  • Loading branch information
@fluiddot
fluiddot committed Jul 8, 2021
commit f9c347f369761c7b084e95dc5a18786f09a0bce4
17 changes: 3 additions & 14 deletions packages/block-library/src/embed/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,8 @@ export const createUpgradedEmbedBlock = (
props,
attributesFromPreview = {}
) => {
const {
preview,
attributes: {
align,
allowResponsive,
caption,
url,
providerNameSlug,
type,
} = {},
} = props;
const { preview, attributes = {} } = props;
const { url, providerNameSlug, type, ...restAttributes } = attributes;

if ( ! url || ! getBlockType( DEFAULT_EMBED_BLOCK ) ) return;

Expand All @@ -124,10 +115,8 @@ export const createUpgradedEmbedBlock = (
! providerNameSlug );
if ( shouldCreateNewBlock ) {
return createBlock( DEFAULT_EMBED_BLOCK, {
align,
allowResponsive,
caption,
url,
...restAttributes,
...matchedBlock.attributes,
} );
}
Expand Down