Skip to content

Conversation

@SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Oct 27, 2021

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#4170

Description

At the moment, anyone running on an M1 Mac who wishes to run Gutenberg's demo app for Android would need to manually add support for arm64-v8a.

With this PR, support is enabled by default, by adding arm64-v8a to abiFilters in the project's Gradle configuration.

How has this been tested?

The demo app still runs as expected on a Mac with an 8-Core Intel Core i9 processor, confirming there are no unexpected regressions for 'non-M1' machines.

This will also need to be tested by someone with a machine that has the M1 chip, to confirm that the demo app runs smoothly for them with no necessary changes to the Gradle configuration.

Types of changes

Non-breaking change to code, to enable support, involving the addition of arm64-v8a to abiFilters in packages/react-native-editor/android/app/build.gradle.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 27, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SiobhyB! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@SiobhyB SiobhyB added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement. and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Oct 27, 2021
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Oct 27, 2021

Requesting reviews from @gwwar as this PR came up following our recent conversations and also @oguzkocer as this involves changes to our Gradle configuration, I want to be certain that this won't cause any issues. Let me know if I can clarify anything! Thanks in advance 🙇‍♀️

@SiobhyB SiobhyB requested review from gwwar and oguzkocer October 27, 2021 18:26
@SiobhyB SiobhyB marked this pull request as ready for review October 27, 2021 18:26
@SiobhyB SiobhyB changed the title [RNMobile] Enable Support for 'arm64-v8a' [RNMobile] Enable Support for 'arm64-v8a' in Gradle Configuration Oct 27, 2021
@SiobhyB SiobhyB changed the title [RNMobile] Enable Support for 'arm64-v8a' in Gradle Configuration [RNMobile] Enable Support for 'arm64-v8a' in Android's Gradle Configuration Oct 27, 2021
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly this is not something I have any prior experience with. Looking at the Android developer docs specifying extra architectures shouldn't cause any issues, although I do wonder if they needed to be specified in the first place, but this is not relevant to this PR.

As long as it works as expected, I think this is good 🤷 I'll leave the testing to @gwwar as I don't have my M1 machine setup to test this right now.

Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding this @SiobhyB Running npm run native android works for me now. I tested this on a MacBook Pro (13-inch, M1, 2020.)

I also didn't need to download the extra Platform S packages, noted in #35529 (comment)

before after
138781247-8c761d45-e4de-4e5f-8537-ea96e3270032 CleanShot 2021-10-27 at 11 48 31@2x

@SiobhyB SiobhyB merged commit b48045f into trunk Oct 27, 2021
@SiobhyB SiobhyB deleted the rnmobile/add/support-for-arm64-v8a branch October 27, 2021 19:22
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants