-
Notifications
You must be signed in to change notification settings - Fork 57
Enable Support for 'arm64-v8a' in Android's Gradle Configuration #4170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SiobhyB Do you mind pinging a gb-mobile developer for this review? I can approve it if you'd like because the linked PR looks good to me, but this PR includes more changes than the |
|
Thanks, @oguzkocer, that makes sense! @twstokes has kindly offered his help here :D |
|
LGTM @SiobhyB! 🎉 Thanks so much for getting this change in! I was able to run the demo project from my M1 Mac. I will add one note: My Mac carries over my previous configuration changes that you mentioned here, so this wasn't tested with a purely clean fresh start, but this comment makes me think those steps may not be necessary anymore. |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Due to frozen tests following a CircleCI outage, I haven't been able to merge this PR yet. In the process of waiting, a new PR with a more recent Gutenberg ref has been created at #4173. To avoid conflicts, I'll close this PR to make way for that newer PR, which will pick up these changes. |
gutenberg:WordPress/gutenberg#36007At the moment, anyone running on an M1 Mac who wishes to run Gutenberg's demo app for Android would need to manually add support for
arm64-v8a.With this PR, support is enabled by default, by adding
arm64-v8atoabiFiltersin the project's Gradle configuration.To test: Please refer to the Gutenberg PR as the central, most up-to-date place for testing instructions.
PR submission checklist: