Skip to content

Conversation

@SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Oct 27, 2021

gutenberg: WordPress/gutenberg#36007

At the moment, anyone running on an M1 Mac who wishes to run Gutenberg's demo app for Android would need to manually add support for arm64-v8a.

With this PR, support is enabled by default, by adding arm64-v8a to abiFilters in the project's Gradle configuration.

To test: Please refer to the Gutenberg PR as the central, most up-to-date place for testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB self-assigned this Oct 27, 2021
@SiobhyB SiobhyB added [Type] Enhancement Improves a current area of the editor [OS] Android labels Oct 27, 2021
@SiobhyB SiobhyB changed the title Enable Support for 'arm64-v8a' Enable Support for 'arm64-v8a' in Gradle Configuration Oct 27, 2021
@SiobhyB SiobhyB marked this pull request as ready for review October 27, 2021 18:27
@SiobhyB SiobhyB requested a review from oguzkocer October 27, 2021 18:27
@SiobhyB SiobhyB changed the title Enable Support for 'arm64-v8a' in Gradle Configuration Enable Support for 'arm64-v8a' in Android's Gradle Configuration Oct 27, 2021
@oguzkocer
Copy link
Contributor

@SiobhyB Do you mind pinging a gb-mobile developer for this review? I can approve it if you'd like because the linked PR looks good to me, but this PR includes more changes than the abiFilters change so it might be better if a gb-mobile developer takes a look instead.

@SiobhyB SiobhyB requested a review from twstokes October 27, 2021 18:59
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Oct 27, 2021

Thanks, @oguzkocer, that makes sense! @twstokes has kindly offered his help here :D

@twstokes
Copy link
Contributor

LGTM @SiobhyB! 🎉 Thanks so much for getting this change in! I was able to run the demo project from my M1 Mac.

I will add one note: My Mac carries over my previous configuration changes that you mentioned here, so this wasn't tested with a purely clean fresh start, but this comment makes me think those steps may not be necessary anymore.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 27, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB enabled auto-merge October 27, 2021 19:32
@SiobhyB SiobhyB disabled auto-merge October 27, 2021 21:01
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Oct 27, 2021

Due to frozen tests following a CircleCI outage, I haven't been able to merge this PR yet. In the process of waiting, a new PR with a more recent Gutenberg ref has been created at #4173. To avoid conflicts, I'll close this PR to make way for that newer PR, which will pick up these changes.

@SiobhyB SiobhyB closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[OS] Android [Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants