fix text columns undefined index #3714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, thanks, I missed this when opening #3715. |
Contributor
Author
|
@mtias It's OK, should I close this one? |
mcsf
approved these changes
Nov 29, 2017
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Thanks for the fix, @vladanost!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3710
When adding new columns new index does not exist in the content array.
How Has This Been Tested?
npm run test-unit
Manually tested in the browser
Types of changes
Checking for the index before use. That seemed like an easiest fix. I could maybe try to push empty array to content on RangeControl change?