Skip to content

Conversation

@mtias
Copy link
Member

@mtias mtias commented Nov 29, 2017

Closes #3709.

cc @gziolo we need more testes for these kind of things — either snapshots or e2e for every block.

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Nov 29, 2017
@gziolo
Copy link
Member

gziolo commented Nov 29, 2017

cc @gziolo we need more testes for these kind of things — either snapshots or e2e for every block.

Yes, I was surprised that we don't have any way to tests all existing blocks. Those should be tackled on the higher level as blocks are usually composed of a few different pieces. I will explore it further as this is something that would be beneficial for plugin developers, too. Snapshots testing might be useful for the <BlockEdit /> part to validate if edit method works as expected. However to test transforms or attribute changes we might need an editor instance which would be closer to e2e testing.

@gziolo
Copy link
Member

gziolo commented Nov 29, 2017

This includes changes merged with #3714. Label update looks ok 👍

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants