Try to optimize getClientIdsOfDescendants using createSelector memoization.
#40112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Performance
|
Size Change: +1 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 7, 2022
| descendantId, | ||
| ...getClientIdsOfDescendants( state, [ descendantId ] ) | ||
| ); | ||
| export const getClientIdsOfDescendants = createSelector( |
Contributor
There was a problem hiding this comment.
This should have been memoized anyway, I don't think that's what caused the regression though but let's see.
ZebulanStanphill
deleted the
update/optimize-descendant-client-ids-selectors-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #40054, which appears to have had minimal effect on performance.
This PR attempts to optimize
getClientIdsOfDescendantsusing memoization.Why?
#39985 seems to have reduced performance a bit, and #40054 doesn't seem to have done much to counteract that.
How?
This PR wraps
getClientIdsOfDescendantsincreateSelector, which should help memoize the selector.getClientIdsWithDescendantswas already usingcreateSelector, so I think this makes sense.Testing Instructions
Check the "Performances Tests" in the PR checks to get an initial impression. If it looks promising, I guess try merging this and monitor the "Block Select" metric at http://codehealth.vercel.app/ over the next several commits in
trunk.