Skip to content

Try to optimize getClientIdsOfDescendants using createSelector memoization. #40112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZebulanStanphill merged 1 commit into from
Apr 7, 2022
Merged

Try to optimize getClientIdsOfDescendants using createSelector memoization. #40112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions packages/block-editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,18 +225,21 @@ export const __unstableGetClientIdsTree = createSelector(
*
* @return {Array} ids of descendants.
*/
export const getClientIdsOfDescendants = ( state, clientIds ) => {
const collectedIds = [];
for ( const givenId of clientIds ) {
for ( const descendantId of getBlockOrder( state, givenId ) ) {
collectedIds.push(
descendantId,
...getClientIdsOfDescendants( state, [ descendantId ] )
);
export const getClientIdsOfDescendants = createSelector(
Copy link
Contributor

@youknowriad youknowriad Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been memoized anyway, I don't think that's what caused the regression though but let's see.

( state, clientIds ) => {
const collectedIds = [];
for ( const givenId of clientIds ) {
for ( const descendantId of getBlockOrder( state, givenId ) ) {
collectedIds.push(
descendantId,
...getClientIdsOfDescendants( state, [ descendantId ] )
);
}
}
}
return collectedIds;
};
return collectedIds;
},
( state ) => [ state.blocks.order ]
);

/**
* Returns an array containing the clientIds of the top-level blocks and
Expand Down