Latest Posts block: remove columns-x class for list view
#4017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just uses the stock WordPress objects.
Adds test cases to fully cover the REQUEST_POST_UPDATE_SUCCESS effect.
| } | ||
|
|
||
| if ( isset( $attributes['columns'] ) ) { | ||
| if ( isset( $attributes['columns'] ) && 'grid' === $attributes['layout'] ) { |
Contributor
There was a problem hiding this comment.
Based on the surrounding code, it looks like this should check to make sure the layout key exists before checking its value.
Member
Author
Member
There was a problem hiding this comment.
We might still want the 'grid' === $attributes['layout'] check though since based on the behavior in the editor, it seems that columns are only relevant for the grid layout. Edit: Ah, that's the whole point of the PR I see 😅
This changes the opacity of a disabled button to be .3 opacity from .6 previously. This fixes #3928
…st-post-update-success Add full coverage for REQUEST_POST_UPDATE_SUCCESS effect.
Try fainter disabled state
aduth
approved these changes
Dec 15, 2017
Fix blocks when useOnce is true
Components: Add withState higher-order component
Block API: Refactor supportHTML as supports property
…dynamic Make the block settings menu item dynamic
When there are no Reusable Blocks available to add, and the user selects 'Saved' in the Inserter, display a message instead of a completely blank tab.
We were requesting all category fields while needing three of them, this change makes sure we request only the fields we need.
The mixins apply editor left/right position to the selector passed as argument. It allows to use position fixed with correct dimensions.
…dths lower than small breakpoint. Used editor-left & editor-right mixins to correctly position notices.
This change removes duplicate code and solves a bug related with resizing to small screen expanding WordPress menu and then resizing back to big screen.
Add 'No saved blocks' message to Inserter
…o-api Add ability to delete a Reusable Block to REST API
For more performance
* Bump `node-sass` to latest 4.7.2 release * Update `package-lock.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
columns-xclass for list view in the Latest Posts block. This class is only necessary for grid view.Fixes #4015