Skip to content

Add Featured Image, Title and Excerpt to top of the settings sidebar #42352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noisysocks wants to merge 12 commits into from
Closed

Add Featured Image, Title and Excerpt to top of the settings sidebar #42352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4dbafb2
Add Featured Image, Title and Excerpt to top of the settings sidebar
noisysocks Jul 13, 2022
4432a4c
Improve how title margin is counteracted
noisysocks Jul 13, 2022
00f0a5d
Prevent Close tooltip from appearing
noisysocks Jul 13, 2022
eac5d3f
Add pencil icon to featured image button
noisysocks Jul 13, 2022
b3623d0
Update dead code comment
noisysocks Jul 13, 2022
67d9a55
Fix empty section when excerpt and title are not supported
noisysocks Jul 14, 2022
82a11a5
Remove unused class
noisysocks Jul 14, 2022
32d49eb
Update unit tests
noisysocks Jul 14, 2022
08cf295
Update e2e tests
noisysocks Jul 14, 2022
17947ca
Deprecate PostExcerptCheck, which doesn't add much
noisysocks Jul 14, 2022
db626c5
Open menu below featured image button
noisysocks Jul 19, 2022
c03d63c
Make menu navigable
noisysocks Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update unit tests
  • Loading branch information
@noisysocks
noisysocks committed Jul 14, 2022
commit 32d49ebe31aea513116f2e944c67b65c39aaf84a
32 changes: 4 additions & 28 deletions packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,7 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
<WithSelect(PostTaxonomies)
taxonomyWrapper={[Function]}
/>
<PostFeaturedImageCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Featured image"
panelName="featured-image"
/>
</PostFeaturedImageCheck>
<PostExcerptCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Excerpt"
panelName="post-excerpt"
/>
</PostExcerptCheck>
<WithSelect(PostTypeSupportCheck)
<PostTypeSupportCheck
supportKeys={
Array [
"comments",
Expand All @@ -118,7 +106,7 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
label="Discussion"
panelName="discussion-panel"
/>
</WithSelect(PostTypeSupportCheck)>
</PostTypeSupportCheck>
<PageAttributesCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Page attributes"
Expand Down Expand Up @@ -225,19 +213,7 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
<WithSelect(PostTaxonomies)
taxonomyWrapper={[Function]}
/>
<PostFeaturedImageCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Featured image"
panelName="featured-image"
/>
</PostFeaturedImageCheck>
<PostExcerptCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Excerpt"
panelName="post-excerpt"
/>
</PostExcerptCheck>
<WithSelect(PostTypeSupportCheck)
<PostTypeSupportCheck
supportKeys={
Array [
"comments",
Expand All @@ -249,7 +225,7 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
label="Discussion"
panelName="discussion-panel"
/>
</WithSelect(PostTypeSupportCheck)>
</PostTypeSupportCheck>
<PageAttributesCheck>
<WithSelect(IfCondition(WithDispatch(BaseOption)))
label="Page attributes"
Expand Down
93 changes: 62 additions & 31 deletions packages/editor/src/components/post-type-support-check/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,80 +3,111 @@
*/
import { create } from 'react-test-renderer';

/**
* WordPress dependencies
*/
import { createRegistry, RegistryProvider } from '@wordpress/data';

/**
* Internal dependencies
*/
import { PostTypeSupportCheck } from '../';
import PostTypeSupportCheck from '../';

function createMockRegistry( postType ) {
return createRegistry( {
'core/editor': {
selectors: {
getEditedPostAttribute: () => 'post',
},
reducer: ( state = {} ) => state,
},
core: {
selectors: {
getPostType: () => postType,
},
reducer: ( state = {} ) => state,
},
} );
}

describe( 'PostTypeSupportCheck', () => {
it( 'renders its children when post type is not known', () => {
let postType;
const registry = createMockRegistry( null );

const tree = create(
<PostTypeSupportCheck postType={ postType } supportKeys="title">
Supported
</PostTypeSupportCheck>
<RegistryProvider value={ registry }>
<PostTypeSupportCheck supportKeys="title">
Supported
</PostTypeSupportCheck>
</RegistryProvider>
);

expect( tree.toJSON() ).toBe( 'Supported' );
} );

it( 'does not render its children when post type is known and not supports', () => {
const postType = {
const registry = createMockRegistry( {
supports: {},
};
} );

const tree = create(
<PostTypeSupportCheck postType={ postType } supportKeys="title">
Supported
</PostTypeSupportCheck>
<RegistryProvider value={ registry }>
<PostTypeSupportCheck supportKeys="title">
Supported
</PostTypeSupportCheck>
</RegistryProvider>
);

expect( tree.toJSON() ).toBe( null );
} );

it( 'renders its children when post type is known and supports', () => {
const postType = {
const registry = createMockRegistry( {
supports: {
title: true,
},
};
} );

const tree = create(
<PostTypeSupportCheck postType={ postType } supportKeys="title">
Supported
</PostTypeSupportCheck>
<RegistryProvider value={ registry }>
<PostTypeSupportCheck supportKeys="title">
Supported
</PostTypeSupportCheck>
</RegistryProvider>
);

expect( tree.toJSON() ).toBe( 'Supported' );
} );

it( 'renders its children if some of keys supported', () => {
const postType = {
const registry = createMockRegistry( {
supports: {
title: true,
},
};
} );

const tree = create(
<PostTypeSupportCheck
postType={ postType }
supportKeys={ [ 'title', 'thumbnail' ] }
>
Supported
</PostTypeSupportCheck>
<RegistryProvider value={ registry }>
<PostTypeSupportCheck supportKeys={ [ 'title', 'thumbnail' ] }>
Supported
</PostTypeSupportCheck>
</RegistryProvider>
);

expect( tree.toJSON() ).toBe( 'Supported' );
} );

it( 'does not render its children if none of keys supported', () => {
const postType = {
const registry = createMockRegistry( {
supports: {},
};
} );

const tree = create(
<PostTypeSupportCheck
postType={ postType }
supportKeys={ [ 'title', 'thumbnail' ] }
>
Supported
</PostTypeSupportCheck>
<RegistryProvider value={ registry }>
<PostTypeSupportCheck supportKeys={ [ 'title', 'thumbnail' ] }>
Supported
</PostTypeSupportCheck>
</RegistryProvider>
);

expect( tree.toJSON() ).toBe( null );
Expand Down