Skip to content

Add Featured Image, Title and Excerpt to top of the settings sidebar #42352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noisysocks wants to merge 12 commits into from
Closed

Add Featured Image, Title and Excerpt to top of the settings sidebar #42352

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4dbafb2
Add Featured Image, Title and Excerpt to top of the settings sidebar
noisysocks Jul 13, 2022
4432a4c
Improve how title margin is counteracted
noisysocks Jul 13, 2022
00f0a5d
Prevent Close tooltip from appearing
noisysocks Jul 13, 2022
eac5d3f
Add pencil icon to featured image button
noisysocks Jul 13, 2022
b3623d0
Update dead code comment
noisysocks Jul 13, 2022
67d9a55
Fix empty section when excerpt and title are not supported
noisysocks Jul 14, 2022
82a11a5
Remove unused class
noisysocks Jul 14, 2022
32d49eb
Update unit tests
noisysocks Jul 14, 2022
08cf295
Update e2e tests
noisysocks Jul 14, 2022
17947ca
Deprecate PostExcerptCheck, which doesn't add much
noisysocks Jul 14, 2022
db626c5
Open menu below featured image button
noisysocks Jul 19, 2022
c03d63c
Make menu navigable
noisysocks Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make menu navigable
  • Loading branch information
@noisysocks
noisysocks committed Jul 19, 2022
commit c03d63cce015d069202f8425d58cb7a74a027006
60 changes: 31 additions & 29 deletions packages/editor/src/components/post-featured-image/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* WordPress dependencies
*/
import { __experimentalInspectorPopoverHeader as InspectorPopoverHeader } from '@wordpress/block-editor';
import { MenuGroup, MenuItem } from '@wordpress/components';
import { NavigableMenu, MenuGroup, MenuItem } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import {
media as mediaIcon,
Expand All @@ -25,41 +25,43 @@ export default function PostFeaturedImageMenu( {
title={ title }
onClose={ onClose }
/>
<MenuGroup>
<MenuItem
icon={ mediaIcon }
iconPosition="left"
onClick={ () => {
onOpenMediaLibrary();
onClose();
} }
>
{ __( 'Open Media Library' ) }
</MenuItem>
<MenuItem
icon={ uploadIcon }
iconPosition="left"
onClick={ () => {
onOpenFileDialog();
onClose();
} }
>
{ __( 'Upload file' ) }
</MenuItem>
{ onRemoveImage && (
<NavigableMenu>
<MenuGroup>
<MenuItem
icon={ trashIcon }
icon={ mediaIcon }
iconPosition="left"
isDestructive
onClick={ () => {
onRemoveImage();
onOpenMediaLibrary();
onClose();
} }
>
{ removeImageLabel }
{ __( 'Open Media Library' ) }
</MenuItem>
) }
</MenuGroup>
<MenuItem
icon={ uploadIcon }
iconPosition="left"
onClick={ () => {
onOpenFileDialog();
onClose();
} }
>
{ __( 'Upload file' ) }
</MenuItem>
{ onRemoveImage && (
<MenuItem
icon={ trashIcon }
iconPosition="left"
isDestructive
onClick={ () => {
onRemoveImage();
onClose();
} }
>
{ removeImageLabel }
</MenuItem>
) }
</MenuGroup>
</NavigableMenu>
</div>
);
}