Post Editor: Avoid 403 errors for users with low permissions #42413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +4.22 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
talldan
approved these changes
Jul 18, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Looks good. In testing it prevents the 403 errors 👍
packages/editor/src/components/provider/use-block-editor-settings.js
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the review, @talldan! |
Member
|
I would love to see #48885 find it's way into core. This too would solve this issue. |
Member
Author
|
@spacedmonkey, that would be a significant improvement. |
Member
@Mamaduka Do feel free to test my PR. WordPress/wordpress-develop#2985 |
getdave
added a commit
that referenced
this pull request
Jul 20, 2022
These errors were avoided in #42413
37 tasks
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 6, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54084 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 6, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. Built from https://develop.svn.wordpress.org/trunk@54084 git-svn-id: http://core.svn.wordpress.org/trunk@53643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 6, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. Built from https://develop.svn.wordpress.org/trunk@54084 git-svn-id: https://core.svn.wordpress.org/trunk@53643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne
pushed a commit
to pbearne/wordpress-develop
that referenced
this pull request
Sep 9, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54084 602fd350-edb4-49c9-b593-d223f7449a82
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. Built from https://develop.svn.wordpress.org/trunk@54084
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
This is a path for following changes in the Gutenberg plugin: * [WordPress/gutenberg#42209 #42209: Post Editor: Preload templates post type permissions] * [WordPress/gutenberg#42413 #42413: Post Editor: Avoid 403 errors for users with low permissions]. Follow-up to [43815], [44172], [46110], [51962], [52995]. Props Mamaduka, bernhard-reiter, TimothyBlynJacobs. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54084 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes 403 errors in the post editor for low capability users, like authors.
Similar issue #29845.
Why?
The editor should check permission before making requests when data isn't available for everyone.
How?
canEditTemplatecheck before requestinggetEditedPostTemplate. Authors can't edit templates, so there's no need for this data.canUser( 'read', 'settings' )check inuseBlockEditorSettingsbefore request site settings.OPTIONS /wp/v2/settingssince the request is made in the critical path. The settings endpoint has been preloaded since Optimize preload paths for post and site editors #39256.Testing Instructions
Screenshots or screencast