Skip to content

Post Editor: Avoid 403 errors for users with low permissions #42413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Jul 18, 2022
Merged

Post Editor: Avoid 403 errors for users with low permissions #42413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
297fcc0
Post Editor: Avoid 403 errors for low capability users
Mamaduka Jul 14, 2022
e6a3efa
Use undefined
Mamaduka Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/compat/wordpress-6.1/edit-form-blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
function gutenberg_preload_template_permissions( $preload_paths, $context ) {
if ( ! empty( $context->post ) ) {
$preload_paths[] = array( rest_get_route_for_post_type_items( 'wp_template' ), 'OPTIONS' );
$preload_paths[] = array( '/wp/v2/settings', 'OPTIONS' );
}

return $preload_paths;
Expand Down
5 changes: 3 additions & 2 deletions packages/edit-post/src/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function Editor( {
getEditedPostTemplate,
getHiddenBlockTypes,
} = select( editPostStore );
const { getEntityRecord, getPostType, getEntityRecords } =
const { getEntityRecord, getPostType, getEntityRecords, canUser } =
select( coreStore );
const { getEditorSettings } = select( editorStore );
const { getBlockTypes } = select( blocksStore );
Expand All @@ -77,6 +77,7 @@ function Editor( {
const supportsTemplateMode =
getEditorSettings().supportsTemplateMode;
const isViewable = getPostType( postType )?.viewable ?? false;
const canEditTemplate = canUser( 'create', 'templates' );

return {
hasFixedToolbar:
Expand All @@ -94,7 +95,7 @@ function Editor( {
keepCaretInsideBlock: isFeatureActive( 'keepCaretInsideBlock' ),
isTemplateMode: isEditingTemplate(),
template:
supportsTemplateMode && isViewable
supportsTemplateMode && isViewable && canEditTemplate
? getEditedPostTemplate()
: null,
post: postObject,
Expand Down
4 changes: 3 additions & 1 deletion packages/editor/src/components/provider/use-block-editor-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ function useBlockEditorSettings( settings, hasTemplate ) {
const isWeb = Platform.OS === 'web';
const { canUser, getEntityRecord } = select( coreStore );

const siteSettings = getEntityRecord( 'root', 'site' );
const siteSettings = canUser( 'read', 'settings' )
? getEntityRecord( 'root', 'site' )
: undefined;

return {
canUseUnfilteredHTML: canUserUseUnfilteredHTML(),
Expand Down