FormTokenField: use KeyboardEvent.code, refactor tests to model RTL and user-event #43442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/form-token-field-keycode-code
branch
from
432d5c1 to
fed3197
Compare
ciampo
added
[Type] Enhancement
ciampo
commented
Aug 23, 2022
tyxla
approved these changes
Aug 23, 2022
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
I'm in love with the way you write tests: elegant, eloquent, thorough, well-described, and easy to follow ❤️ Thanks a lot for your brilliant work here! 💯
I've left a few suggestions, but it's just minor optional stuff, this already looks ready to go.
🚀 🚢
ciampo
commented
Aug 23, 2022
ciampo
commented
Aug 23, 2022
ciampo
commented
Aug 23, 2022
ciampo
commented
Aug 23, 2022
ciampo
force-pushed
the
refactor/form-token-field-keycode-code
branch
from
a068b32 to
94e42d9
Compare
Contributor
Author
|
Thank you for your review, I'm humbled 🙇 All feedback has been addressed, will wait for CI to ✅ and merge |
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
ciampo
force-pushed
the
refactor/form-token-field-keycode-code
branch
from
94e42d9 to
9435de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
FormTokenFieldcomponent to rely oncodeinstead ofkeyCodefor keyboard events.fireEvent, I went ahead and rewrote the whole test suite in TypeScript, usinguserEventand with "modern" RTL style (i.e. avoiding implementation details).__experimentalExpandOnFocusactually made the suggestions always visible (not just when focused)__experimentalAutoSelectFirstMatch's value changedOn top of that, here's list of things that I noticed and could be improved:
autoCompleteprop is listed as a value accepted by the component, but it doesn't seem to have any impact (since it gets overridden tooff)listboxelement can be rendered even if there are no suggestions passed via prop (for example, if the__experimentalExpandOnFocusis true and the component gets focused)titleattribute set)__experimentalRenderSuggestionwould probably be a better name for__experimentalRenderItem, and shoudl it allow for extra props?Why?
keyCodeis deprecated, and replaced bycodeWe're also rewriting our unit tests to RTL