[Mobile] - Add new KeyboardEvent.code attribute to RichText onKeyPress event #43521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
geriux
commented
Aug 23, 2022
Member
Author
There was a problem hiding this comment.
I didn't use the values from @wordpress/keycodes just in case those get deprecated with this keyCode being deprecated effort.
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
tyxla
reviewed
Aug 23, 2022
Member
There was a problem hiding this comment.
I'd also suggest adding Space and Delete as those are used in #43442.
Feel free to borrow from this keymap if that helps: https://github.com/testing-library/user-event/blob/main/src/keyboard/keyMap.ts
Member
Author
There was a problem hiding this comment.
Great idea! I'll add those, thank you @tyxla 🙇
Member
There was a problem hiding this comment.
Let me know if you need reviews FWIW. I owe you a few already 😉
dcalhoun
reviewed
Aug 24, 2022
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Thank you for addressing this issue! The outlined tests succeeded for me on an iPhone SE (iOS 16) and Samsung Galaxy S20 (Android 12). 🎉
I left a couple of comments for consideration. Let me know what you think. 🙇🏻
…anges on the web editor using KeyboardEvent.code since codeKey is now deprecated.
geriux
force-pushed
the
rnmobile/fix/deprecated-keycodes
branch
from
8888efe to
15db467
Compare
Member
Author
dcalhoun
approved these changes
Aug 24, 2022
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
🚀 Nicely done! I retested the changes. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Gutenberg Mobile-> [Mobile] - Add new KeyboardEvent.code attribute to RichText onKeyPress event wordpress-mobile/gutenberg-mobile#5114What?
This PR adds the
codeattribute to the key events sent from theAztecViewcomponent.Why?
Since keyCode is deprecated and there's an ongoing effort to replace it with code values, we are adding this on the native side to match with the web editor.
It also fixes a regression with the slash inserter (Autocomplete).
How?
By adding the
codeattribute for the key press events in theAztecViewcomponent. It matches the native key values with the Web API values.Testing Instructions
/in a Paragraph block and type the name of a blockScreenshots or screencast