Skip to content

[Mobile] - Add new KeyboardEvent.code attribute to RichText onKeyPress event #43521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 1 commit into from
Aug 24, 2022
Merged

[Mobile] - Add new KeyboardEvent.code attribute to RichText onKeyPress event #43521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions packages/react-native-aztec/src/AztecView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,17 @@ import {
* WordPress dependencies
*/
import { Component, createRef } from '@wordpress/element';
import { ENTER, BACKSPACE } from '@wordpress/keycodes';
import {
BACKSPACE,
DELETE,
DOWN,
ENTER,
ESCAPE,
LEFT,
RIGHT,
SPACE,
UP,
} from '@wordpress/keycodes';

/**
* Internal dependencies
Expand All @@ -21,6 +31,19 @@ import * as AztecInputState from './AztecInputState';

const AztecManager = UIManager.getViewManagerConfig( 'RCTAztecView' );

// Used to match KeyboardEvent.code values (from the Web API) with native keycodes.
const KEYCODES = {
[ BACKSPACE ]: 'Backspace',
[ DELETE ]: 'Delete',
[ DOWN ]: 'ArrowDown',
[ ENTER ]: 'Enter',
[ ESCAPE ]: 'Escape',
[ LEFT ]: 'ArrowLeft',
[ RIGHT ]: 'ArrowRight',
[ SPACE ]: 'Space',
[ UP ]: 'ArrowUp',
};

class AztecView extends Component {
constructor() {
super( ...arguments );
Expand Down Expand Up @@ -75,7 +98,7 @@ class AztecView extends Component {

const { onKeyDown } = this.props;

const newEvent = { ...event, keyCode: ENTER };
const newEvent = { ...event, keyCode: ENTER, code: KEYCODES[ ENTER ] };
onKeyDown( newEvent );
}

Expand All @@ -89,6 +112,7 @@ class AztecView extends Component {
const newEvent = {
...event,
keyCode: BACKSPACE,
code: KEYCODES[ BACKSPACE ],
preventDefault: () => {},
};
onKeyDown( newEvent );
Expand All @@ -100,9 +124,13 @@ class AztecView extends Component {
}

const { onKeyDown } = this.props;
const { keyCode } = event.nativeEvent;
const newEvent = {
...event,
keyCode: event.nativeEvent.keyCode,
keyCode,
...( KEYCODES[ keyCode ] && {
code: KEYCODES[ keyCode ],
} ),
preventDefault: () => {},
};
onKeyDown( newEvent );
Expand Down