Better handling of loading states for navigation selector #43904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disables the button of the dropdown - disables the button to create new menu - enables focus preservation on disabled buttons - handles multiple clicks Co-authored-by: Daniel Richards <[email protected]>
draganescu
added
[Type] Bug
|
Size Change: +191 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Contributor
|
It seems that is still clickable 😢 I'm using slow 3G. Screen.Recording.2022-09-06.at.15.14.43.mov |
Contributor
|
@draganescu It looks like you can remove Though I personally find it a little confusing the way edit: Tested the PR and it works well for me. 👍 |
Co-authored-by: Daniel Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43901
What?
DropdowntoggleWhy?
In #42987 the control to switch the menu used by a Navigation block only shows busy UI but it remains clickable. This
How?
Implementing both
isBusyanddisabledbut with the addition of__experimentalIsFocusable.Testing Instructions