Skip to content

Better handling of loading states for navigation selector #43904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 2 commits into from
Sep 7, 2022
Merged

Better handling of loading states for navigation selector #43904

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9010e64
Disables the buttons for the navigation selector during transactions:
draganescu Sep 6, 2022
50a613f
Refactor the navigation selector for better readability of code.
draganescu Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disables the buttons for the navigation selector during transactions: 
- disables the button of the dropdown
- disables the button to create new menu
- enables focus preservation on disabled buttons
- handles multiple clicks

Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com>
  • Loading branch information
@draganescu @talldan
draganescu and talldan committed Sep 6, 2022
commit 9010e64a3c5f4a73a5012f6b5e59b0efc72c9dea
2 changes: 2 additions & 0 deletions packages/block-library/src/navigation/edit/navigation-menu-selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ function NavigationMenuSelector( {
</>
),
isBusy: ! enableOptions,
disabled: ! enableOptions,
__experimentalIsFocusable: true,
onClick: () => {
setIsPressed( ! isPressed );
},
Expand Down