-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ToolTip: refactor using ariakit #48440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
73f1884
Add ariakit dependency
brookewp 488f4c9
Initial creation of component
brookewp f69c2c8
Add shortcut from legacy tooltip
brookewp ab1bc4e
Replace initial tests with legacy tooltip tests
brookewp 60ee046
Add anchor styles for tooltip placement
brookewp 16d2d12
Ensure tooltip renders only if one child is passed
brookewp 1aebcf9
Replace query with tooltip role and add user actions to ensure tests …
brookewp 0d20541
Remove forwarding refs to match legacy tooltip
brookewp 6d0eb21
Add legacy positioning
brookewp cfb6c4a
Remove unnecessary code and add describedby id
brookewp 32d654f
Replace cloneElement with Radix Slot
brookewp 5386d21
Replace emotion with sass
brookewp 53fd2cd
Update tests and types
brookewp adc88cb
Updated ariakit package and update-related props and types
brookewp b18b13a
Remove radix-ui/react-slot related package changes
brookewp 9ffb2c9
Add arrow to fix floating-ui errors
brookewp 3e1fcca
Replace zero value in temp fix to avoid NaN errors
brookewp 324ba78
resolve test failures after package update
brookewp 6f6d495
Match legacy styles
brookewp 2eb848a
Hide tooltip onBlur to match legacy behavior
brookewp 64062b4
Revert "resolve test failures after package update"
brookewp e7088d1
Prevent leaking by ensuring tooltip is hidden after each test
brookewp a5c8ff3
Remove ‘overlay’ option to match legacy
brookewp 5c94f87
hide on anchor interact to match legacy
brookewp e40a31c
Temporarily replace placement with position for rollout
brookewp 60e0ac3
Update story after storybook upgrade
brookewp ca2fb50
Update descriptions in readme and types
brookewp 89ad595
Replace legacy tooltip with ariakit tooltip
brookewp a415651
Add test with modal for new Esc feature
brookewp 2207553
Error for multiple children but continue to render anchor without too…
brookewp 52fdc3d
Update snapshots
brookewp 800f258
Update assertions in failing tests
brookewp 875d9b5
Replace waitFor with findBy
brookewp fef59d6
Replace workaround with utility function
brookewp 60ff328
Clean up variables
brookewp 56c353d
Update package-lock
brookewp 4bd9455
Add cleanup to test where toBePositioned was used previously
brookewp ef7d837
Update Changelog
brookewp 814ad63
Merge branch 'trunk' into add/ariakit-tooltip
brookewp 956bffd
Update event handling
brookewp beb9a29
Fix failing test
brookewp 8854357
Add cleanup for other components testing tooltip
brookewp 26059b6
Remove Arrow workaround after floating-ui/core update
brookewp 53a1f1c
Merge branch 'trunk' into add/ariakit-tooltip
brookewp dc53c00
Refine test query to avoid conflict
brookewp bb98faf
Update tests based on feedback
brookewp 50b7f5d
remove unnecessary type and variable
brookewp 75e4ea5
Simplify by removing unnecessary logic and adding default value to po…
brookewp ed4c6aa
Add timeout to test for custom delay
brookewp cf59cd4
Ensure anchor shows when Icon or multiple children
brookewp 6c54d5c
Update types and README
brookewp 45ba198
Merge branch 'trunk' into add/ariakit-tooltip
brookewp 59fec6c
Update snapshots
brookewp b43abd7
Remove type ignore after update in #54101
brookewp 869bdde
Merge branch 'trunk' into add/ariakit-tooltip
brookewp 968add1
Merge branch 'trunk' into add/ariakit-tooltip
ciampo 5761d79
Fix link control tests by querying explicitly for the spinner
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
resolve test failures after package update
- Loading branch information
commit 324ba78bbdec605f9c182dbae44a67d7c309e5bd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.