Skip to content

ToolTip: refactor using ariakit #48440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 57 commits into from
Sep 7, 2023
Merged

ToolTip: refactor using ariakit #48440

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
73f1884
Add ariakit dependency
brookewp Feb 23, 2023
488f4c9
Initial creation of component
brookewp Feb 25, 2023
f69c2c8
Add shortcut from legacy tooltip
brookewp Mar 17, 2023
ab1bc4e
Replace initial tests with legacy tooltip tests
brookewp Mar 17, 2023
60ee046
Add anchor styles for tooltip placement
brookewp Mar 17, 2023
16d2d12
Ensure tooltip renders only if one child is passed
brookewp Mar 17, 2023
1aebcf9
Replace query with tooltip role and add user actions to ensure tests …
brookewp Mar 22, 2023
0d20541
Remove forwarding refs to match legacy tooltip
brookewp Mar 24, 2023
6d0eb21
Add legacy positioning
brookewp Mar 24, 2023
cfb6c4a
Remove unnecessary code and add describedby id
brookewp Mar 24, 2023
32d654f
Replace cloneElement with Radix Slot
brookewp Mar 30, 2023
5386d21
Replace emotion with sass
brookewp Mar 30, 2023
53fd2cd
Update tests and types
brookewp Mar 30, 2023
adc88cb
Updated ariakit package and update-related props and types
brookewp Jul 8, 2023
b18b13a
Remove radix-ui/react-slot related package changes
brookewp Jul 11, 2023
9ffb2c9
Add arrow to fix floating-ui errors
brookewp Jul 21, 2023
3e1fcca
Replace zero value in temp fix to avoid NaN errors
brookewp Jul 25, 2023
324ba78
resolve test failures after package update
brookewp Jul 26, 2023
6f6d495
Match legacy styles
brookewp Jul 27, 2023
2eb848a
Hide tooltip onBlur to match legacy behavior
brookewp Jul 27, 2023
64062b4
Revert "resolve test failures after package update"
brookewp Jul 31, 2023
e7088d1
Prevent leaking by ensuring tooltip is hidden after each test
brookewp Aug 5, 2023
a5c8ff3
Remove ‘overlay’ option to match legacy
brookewp Aug 5, 2023
5c94f87
hide on anchor interact to match legacy
brookewp Aug 8, 2023
e40a31c
Temporarily replace placement with position for rollout
brookewp Aug 8, 2023
60e0ac3
Update story after storybook upgrade
brookewp Aug 10, 2023
ca2fb50
Update descriptions in readme and types
brookewp Aug 10, 2023
89ad595
Replace legacy tooltip with ariakit tooltip
brookewp Aug 12, 2023
a415651
Add test with modal for new Esc feature
brookewp Aug 11, 2023
2207553
Error for multiple children but continue to render anchor without too…
brookewp Aug 12, 2023
52fdc3d
Update snapshots
brookewp Aug 14, 2023
800f258
Update assertions in failing tests
brookewp Aug 15, 2023
875d9b5
Replace waitFor with findBy
brookewp Aug 16, 2023
fef59d6
Replace workaround with utility function
brookewp Aug 17, 2023
60ff328
Clean up variables
brookewp Aug 17, 2023
56c353d
Update package-lock
brookewp Aug 18, 2023
4bd9455
Add cleanup to test where toBePositioned was used previously
brookewp Aug 18, 2023
ef7d837
Update Changelog
brookewp Aug 18, 2023
814ad63
Merge branch 'trunk' into add/ariakit-tooltip
brookewp Aug 21, 2023
956bffd
Update event handling
brookewp Aug 21, 2023
beb9a29
Fix failing test
brookewp Aug 21, 2023
8854357
Add cleanup for other components testing tooltip
brookewp Aug 23, 2023
26059b6
Remove Arrow workaround after floating-ui/core update
brookewp Aug 24, 2023
53a1f1c
Merge branch 'trunk' into add/ariakit-tooltip
brookewp Aug 25, 2023
dc53c00
Refine test query to avoid conflict
brookewp Aug 25, 2023
bb98faf
Update tests based on feedback
brookewp Aug 31, 2023
50b7f5d
remove unnecessary type and variable
brookewp Aug 31, 2023
75e4ea5
Simplify by removing unnecessary logic and adding default value to po…
brookewp Sep 2, 2023
ed4c6aa
Add timeout to test for custom delay
brookewp Sep 2, 2023
cf59cd4
Ensure anchor shows when Icon or multiple children
brookewp Sep 2, 2023
6c54d5c
Update types and README
brookewp Sep 5, 2023
45ba198
Merge branch 'trunk' into add/ariakit-tooltip
brookewp Sep 5, 2023
59fec6c
Update snapshots
brookewp Sep 5, 2023
b43abd7
Remove type ignore after update in #54101
brookewp Sep 6, 2023
869bdde
Merge branch 'trunk' into add/ariakit-tooltip
brookewp Sep 7, 2023
968add1
Merge branch 'trunk' into add/ariakit-tooltip
ciampo Sep 7, 2023
5761d79
Fix link control tests by querying explicitly for the spinner
ciampo Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'trunk' into add/ariakit-tooltip
  • Loading branch information
@ciampo
ciampo committed Sep 7, 2023
commit 968add1d0862c63afe401e6b051ba4257ab71a30

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.