Fix multiple navigation blocks in pattern template #52707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple navigation blocks on a template, the sidebar navigation editor crashes because it tries to output both menus. This checks if we have any navigation menus early, and then dedupes the Ids if we do.
|
Size Change: +25 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Jul 18, 2023
| ( menuId ) => menuId | ||
| ); | ||
|
|
||
| if ( ! uniqueNavigationMenuIds?.length ) { |
Contributor
There was a problem hiding this comment.
I can't see how this could ever be possible, but better safe than sorry I suppose.
scruffian
approved these changes
Jul 18, 2023
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
mburridge
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same navigation block was present in a template, the editor would crash since it was trying to generate a sidebar navigation item for the same keyed item. This dedupes and removes invalid navigation menu ID values before passing it to
<TemplatePartNavigationMenus />.Testing Instructions