Skip to content

Fix multiple navigation blocks in pattern template #52707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scruffian merged 2 commits into from
Jul 18, 2023
Merged

Fix multiple navigation blocks in pattern template #52707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e8b005
Only pass unique menus to the navigation sidebar editor
jeryj Jul 17, 2023
df0e830
Filter out undefined values
jeryj Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...edit-site/src/components/sidebar-navigation-screen-pattern/use-navigation-menu-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,23 @@ export default function useNavigationMenuContent( postType, postId ) {
record?.blocks
);

if ( ! navigationBlocks.length ) {
return;
}

const navigationMenuIds = navigationBlocks?.map(
( block ) => block.attributes.ref
);

if ( ! navigationMenuIds?.length ) {
// Dedupe the Navigation blocks, as you can have multiple navigation blocks in the template.
// Also, filter out undefined values, as blocks don't have an id when initially added.
const uniqueNavigationMenuIds = [ ...new Set( navigationMenuIds ) ].filter(
( menuId ) => menuId
);

if ( ! uniqueNavigationMenuIds?.length ) {
Copy link
Contributor

@scruffian scruffian Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how this could ever be possible, but better safe than sorry I suppose.

return;
}

return <TemplatePartNavigationMenus menus={ navigationMenuIds } />;
return <TemplatePartNavigationMenus menus={ uniqueNavigationMenuIds } />;
}