Skip to content

Font Library: unregister font collection #54701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasbenedetto merged 28 commits into from
Jan 8, 2024
Merged

Font Library: unregister font collection #54701

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fb475a2
remove font collection
matiasbenedetto Sep 21, 2023
a50a2de
add wp_unregister_font_collection function
matiasbenedetto Sep 21, 2023
8b90373
format php
matiasbenedetto Sep 21, 2023
2968267
fix function comment
matiasbenedetto Sep 21, 2023
42a61c5
add tests for unregister_font_collection
matiasbenedetto Sep 21, 2023
27102fa
removig unused variable
matiasbenedetto Sep 21, 2023
da35119
Merge branch 'trunk' into try/unregister-font-collection
matiasbenedetto Oct 10, 2023
7830ff7
update wording on comments
matiasbenedetto Oct 10, 2023
2d6dcd2
Merge branch 'try/unregister-font-collection' of github.com:WordPress…
matiasbenedetto Oct 10, 2023
b7c9113
keep track of unregistered font collection ids in an array
matiasbenedetto Oct 11, 2023
cb28b82
add tests to assure that get_font_collections returns an empty array …
matiasbenedetto Oct 11, 2023
eee0a8d
fix tests
matiasbenedetto Oct 11, 2023
e489991
test the initial empty value of the font library collections
matiasbenedetto Oct 11, 2023
177aa58
format
matiasbenedetto Oct 11, 2023
06a10ea
simplify unregistering of font collections and add _doing_it_wrong call
matiasbenedetto Oct 11, 2023
4d16323
add translation domain
matiasbenedetto Oct 11, 2023
6f2ba86
adding _doing_it_wrong if you are registering collections with the sa…
matiasbenedetto Oct 12, 2023
d9ee03a
updating tests
matiasbenedetto Oct 12, 2023
a07e9fb
replace 6.4.0 by 6.5.0 in comments
matiasbenedetto Oct 12, 2023
e9f7b44
update version
matiasbenedetto Nov 14, 2023
e864318
Merge branch 'trunk' into try/unregister-font-collection
matiasbenedetto Dec 21, 2023
6ca8662
consolidate code as only one function to avoid code repetition
matiasbenedetto Dec 21, 2023
5a2c1ff
create base test case
matiasbenedetto Dec 21, 2023
83525bf
format php
matiasbenedetto Dec 21, 2023
a42fa3f
assertWPError
matiasbenedetto Dec 21, 2023
771e760
check that collection was not unregistered by mistake
matiasbenedetto Dec 21, 2023
5d38c57
calling parent test class mehtods
matiasbenedetto Dec 21, 2023
dcd9770
format php
matiasbenedetto Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/experimental/fonts/font-library/class-wp-font-library.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ public static function register_font_collection( $config ) {
}

/**
* Unregister a previously registered font collection.
* Unregisters a previously registered font collection.
*
* @since 6.4.0
*
* @param string $collection_id Font collection id.
* @param string $collection_id Font collection ID.
* @return bool True if the font collection was unregistered successfully and false otherwise.
*/
public static function unregister_font_collection( $collection_id ) {
Expand Down
4 changes: 2 additions & 2 deletions lib/experimental/fonts/font-library/font-library.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ function wp_register_font_collection( $config ) {

if ( ! function_exists( 'wp_unregister_font_collection' ) ) {
/**
* Unregister Font Collection from the Font Library.
* Unregisters a font collection from the Font Library.
*
* @since 6.4.0
*
* @param string $collection_id The font collection's id.
* @param string $collection_id The font collection ID.
*/
function wp_unregister_font_collection( $collection_id ) {
add_action(
Expand Down