create base test case

phpunit/tests/fonts/font-library/wpFontLibrary/base.php

@@ -0,0 +1,24 @@
+<?php
+/**
+ * Test Case for WP_Font_Library tests.
+ *
+ * @package WordPress
+ * @subpackage Font Library
+ */
+abstract class WP_Font_Library_UnitTestCase extends WP_UnitTestCase {
+	public function reset_font_collections() {
+		// Resets the private static property WP_Font_Library::$collections to empty array.
+		$reflection = new ReflectionClass( 'WP_Font_Library' );
+		$property   = $reflection->getProperty( 'collections' );
+		$property->setAccessible( true );
+		$property->setValue( array() );
+	}
+
+	public function set_up() {
+		$this->reset_font_collections();
+	}
+
+	public function tear_down() {
+		$this->reset_font_collections();
+	}
+}

phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollection.php

@@ -10,20 +10,16 @@
  *
  * @covers WP_Font_Library::get_font_collection
  */
-class Tests_Fonts_WpFontLibrary_GetFontCollection extends WP_UnitTestCase {
+class Tests_Fonts_WpFontLibrary_GetFontCollection extends WP_Font_Library_UnitTestCase {
 
-	public static function set_up_before_class() {
+	public function test_should_get_font_collection() {
 		$my_font_collection_config = array(
 			'id'          => 'my-font-collection',
 			'name'        => 'My Font Collection',
 			'description' => 'Demo about how to a font collection to your WordPress Font Library.',
 			'src'         => path_join( __DIR__, 'my-font-collection-data.json' ),
 		);
-
 		wp_register_font_collection( $my_font_collection_config );
-	}
-
-	public function test_should_get_font_collection() {
 		$font_collection = WP_Font_Library::get_font_collection( 'my-font-collection' );
 		$this->assertInstanceOf( 'WP_Font_Collection', $font_collection );
 	}

phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php

@@ -10,24 +10,7 @@
  *
  * @covers WP_Font_Library::get_font_collections
  */
-class Tests_Fonts_WpFontLibrary_GetFontCollections extends WP_UnitTestCase {
-
-	public function reset_collections() {
-		// Resets the private static property WP_Font_Library::$collections to empty array.
-		$reflection = new ReflectionClass( 'WP_Font_Library' );
-		$property   = $reflection->getProperty( 'collections' );
-		$property->setAccessible( true );
-		$property->setValue( array() );
-	}
-
-	public function set_up() {
-		$this->reset_collections();
-	}
-
-	public function tear_down() {
-		$this->reset_collections();
-	}
-
+class Tests_Fonts_WpFontLibrary_GetFontCollections extends WP_Font_Library_UnitTestCase {
 	public function test_should_get_an_empty_list() {
 		$font_collections = WP_Font_Library::get_font_collections();
 		$this->assertEmpty( $font_collections, 'Should return an empty array.' );

phpunit/tests/fonts/font-library/wpFontLibrary/getFontsDir.php

@@ -10,7 +10,7 @@
  *
  * @covers WP_Font_Library::get_fonts_dir
  */
-class Tests_Fonts_WpFontLibrary_GetFontsDir extends WP_UnitTestCase {
+class Tests_Fonts_WpFontLibrary_GetFontsDir extends WP_Font_Library_UnitTestCase {
 
 	public function test_get_fonts_dir() {
 		$this->assertStringEndsWith( '/wp-content/fonts', WP_Font_Library::get_fonts_dir() );

phpunit/tests/fonts/font-library/wpFontLibrary/getMimeTypes.php

@@ -10,7 +10,7 @@
  *
  * @covers WP_Font_Family_Utils::get_expected_font_mime_types_per_php_version
  */
-class Tests_Fonts_WpFontsFamilyUtils_GetMimeTypes extends WP_UnitTestCase {
+class Tests_Fonts_WpFontsFamilyUtils_GetMimeTypes extends WP_Font_Library_UnitTestCase {
 
 	/**
 	 *

phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php

@@ -10,7 +10,7 @@
  *
  * @covers WP_Font_Library::register_font_collection
  */
-class Tests_Fonts_WpFontLibrary_RegisterFontCollection extends WP_UnitTestCase {
+class Tests_Fonts_WpFontLibrary_RegisterFontCollection extends WP_Font_Library_UnitTestCase {
 
 	public function test_should_register_font_collection() {
 		$config     = array(
@@ -69,11 +69,11 @@ public function test_should_return_error_if_id_is_repeated() {
 		// Register first collection.
 		$collection1 = WP_Font_Library::register_font_collection( $config1 );
 		$this->assertInstanceOf( 'WP_Font_Collection', $collection1, 'A collection should be registered.' );
-
+		
 		// Expects a _doing_it_wrong notice.
 		$this->setExpectedIncorrectUsage( 'WP_Font_Library::register_font_collection' );
 		// Try to register a second collection with same id.
 		$collection2 = WP_Font_Library::register_font_collection( $config2 );
-		$this->assertWPError( $collection2, 'Second collection with the same id should fail.' );
+		$this->assertInstanceOf( 'WP_Error', $collection2, 'Should return an instance of WP_Error.' );
 	}
 }

phpunit/tests/fonts/font-library/wpFontLibrary/setUploadDir.php

@@ -10,7 +10,7 @@
  *
  * @covers WP_Font_Library::set_upload_dir
  */
-class Tests_Fonts_WpFontLibrary_SetUploadDir extends WP_UnitTestCase {
+class Tests_Fonts_WpFontLibrary_SetUploadDir extends WP_Font_Library_UnitTestCase {
 
 	public function test_should_set_fonts_upload_dir() {
 		$defaults = array(

phpunit/tests/fonts/font-library/wpFontLibrary/unregisterFontCollection.php

@@ -10,15 +10,9 @@
  *
  * @covers WP_Font_Library::unregister_font_collection
  */
-class Tests_Fonts_WpFontLibrary_UnregisterFontCollection extends WP_UnitTestCase {
-
-	public function set_up() {
-		// Resets the private static property WP_Font_Library::$collections to empty array.
-		$reflection = new ReflectionClass( 'WP_Font_Library' );
-		$property   = $reflection->getProperty( 'collections' );
-		$property->setAccessible( true );
-		$property->setValue( array() );
+class Tests_Fonts_WpFontLibrary_UnregisterFontCollection extends WP_Font_Library_UnitTestCase {
 
+	public function test_should_unregister_font_collection() {
 		// Registers two mock font collections.
 		$config = array(
 			'id'          => 'mock-font-collection-1',
@@ -35,9 +29,7 @@ public function set_up() {
 			'src'         => 'my-mock-data.json',
 		);
 		WP_Font_Library::register_font_collection( $config );
-	}
 
-	public function test_should_unregister_font_collection() {
 		// Unregister mock font collection.
 		WP_Font_Library::unregister_font_collection( 'mock-font-collection-1' );
 		$collections = WP_Font_Library::get_font_collections();