Components: move ContextSystemProvider out of /ui
#54847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 27, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looks great, thanks! 🚀
I think we could add an "Internal" CHANGELOG entry.
ciampo
reviewed
Sep 27, 2023
brookewp
force-pushed
the
remove/components-ui
branch
from
064e15b to
54aedc7
Compare
|
Flaky tests detected in 54aedc7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6329914558
|
mikachan
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Components: move ContextSystemProvider out of ui folder * Update imports * Remove context folder from ui * Update references in docs/comments * Fix path to older commit Co-authored-by: Marco Ciampini <[email protected]> * Update changelog --------- Co-authored-by: Marco Ciampini <[email protected]>
mikachan
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Components: move ContextSystemProvider out of ui folder * Update imports * Remove context folder from ui * Update references in docs/comments * Fix path to older commit Co-authored-by: Marco Ciampini <[email protected]> * Update changelog --------- Co-authored-by: Marco Ciampini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This expands on the work started in #52953 to remove the
uifolder.Why?
There isn't a need for the
uifolder anymore - more details can be found in above-mentioned PR.The next step will be to move anything still used from
ui/utilstopackages/components/src/utils, so theuifolder can be removed.How?
This moves the
contextfolder out of theuifolder and replaces the imports, links, and mentions ofui/context.Testing Instructions
Tests pass and
npm run buildsucceeds without error