Components: Remove unused components from /ui#52953
Merged
Conversation
|
Size Change: +5.46 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6989960. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5662179505
|
brookewp
approved these changes
Aug 1, 2023
Contributor
brookewp
left a comment
brookewp
left a comment
There was a problem hiding this comment.
This tests well for me! ✅
I appreciate being added to review this, thank you! The new tooltip I've been working on is currently in the ui folder, so I'll make sure to move that out. And when that is ready, we'll be able to remove the ui/tooltip you mentioned and Shortcut. 😄
This was referenced Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes unused components from the
packages/components/src/uifolder.Why?
For context, there is no longer a need to keep a separate
/uifolder around, so we want to move toward removing this extra folder grouping.To begin with, there are a lot of experimental components in this folder that are not used anywhere, and are no longer part of our overall component strategy. They add unnecessary overhead when auditing or just looking for components.
Removed components
ControlGroup: Should be redesigned specifically for Implement a standard "controls grid" component for sidebar #43423.FormGroup,ControlLabel: Superseded byBaseControl.Spinner: Unused, and no plans to use.Not removed (or moved) in this PR
These will be addressed separately.
ContextSystemProvider: Should be moved to root.Tooltip: There is one use in the Gutenberg app, which I believe is pretty unintentional. This use should be replaced with the main Tooltip component.Shortcut: This is a dependency ofTooltip, but is unused elsewhere.Testing Instructions
✅
npm run buildsucceeds without errorFYI, none of these components are exported publicly. The readme files are already excluded from the public docs as well.