Components: consolidate utils to remove ui/#54922
Merged
Conversation
brookewp
added
[Type] Code Quality
|
Size Change: +3 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8a7f424. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6346220760
|
tyxla
approved these changes
Sep 29, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Great work finishing up the /ui cleanup 🙌
Looks and works great to me! ✅
I've only pushed a little commit to remove a couple of old /ui references.
🚀
chad1008
approved these changes
Sep 29, 2023
This was referenced Oct 3, 2023
mikachan
pushed a commit
that referenced
this pull request
Jan 3, 2024
mikachan
added a commit
that referenced
this pull request
Jan 3, 2024
mikachan
pushed a commit
that referenced
this pull request
Jan 5, 2024
mikachan
added a commit
that referenced
this pull request
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remaining task to remove the
ui/folder which started in #52953Why?
There isn't a need for the ui folder anymore - more details can be found in above-mentioned PR.
How?
By moving the files from
ui/utilstoutils.colorswas the only name conflict, so it and its tests have been consolidated into one file.Testing Instructions
Ensure all tests pass