Skip to content

Fix/55278 standardize font library rest api #55454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbking wants to merge 19 commits into from
Closed

Fix/55278 standardize font library rest api #55454

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
da8196d
Refactored the consumption of the API to use singular font family data
pbking Oct 5, 2023
7ce8011
Refactored unit tests to pass with code refactor.
pbking Oct 5, 2023
1b11df3
Renamed test with .spec
pbking Oct 5, 2023
eae4e9e
Refactored test to use toThrow instead of a getError function
pbking Oct 5, 2023
bb8e518
Refactor Font Library API to transfer SINGULAR items
pbking Oct 18, 2023
23c0745
update font collection tests
pbking Oct 18, 2023
47579c7
update font collection tests
pbking Oct 18, 2023
d0a4757
Fixed font family tests
pbking Oct 18, 2023
1e0b21c
Moved Font Collection tests to wpFontCollection folder
pbking Oct 18, 2023
d27f570
Added register font collection test
pbking Oct 18, 2023
5f4c8b5
Adding Font Collections Controller Tests (WIP)
pbking Oct 18, 2023
8215568
Refactored Font Library Controller tests to Font Family Controller Tests
pbking Oct 18, 2023
cfc98f1
Fixed failing font collection tests (when ran in a suite) due to repe…
pbking Oct 18, 2023
71e3f40
Fixed failing font family deletion test
pbking Oct 18, 2023
0a60636
fixed linting errors
pbking Oct 18, 2023
329ee7d
Refactored font collections get_items to use rest_ensure_response
pbking Oct 18, 2023
9af3ae0
Renamed permission callback per request
pbking Nov 7, 2023
40db889
Refactored api parameters to be snake_case instead of camelCase
pbking Nov 8, 2023
ff6d56a
Renamed test classes to align with standards
pbking Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactored test to use toThrow instead of a getError function
  • Loading branch information
@pbking
pbking committed Oct 18, 2023
commit eae4e9e41fc1c9991d836455be303ad069485f21
17 changes: 4 additions & 13 deletions .../src/components/global-styles/font-library-modal/utils/test/makeFamiliesFromFaces.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,6 @@
*/
import makeFamiliesFromFaces from '../make-families-from-faces';

const getError = ( call ) => {
try {
call();
throw new Error( 'No error thrown' );
} catch ( error ) {
return error;
}
};

describe( 'makeFamiliesFromFaces', () => {
it( 'handles empty fontFaces list', () => {
const result = makeFamiliesFromFaces( [] );
Expand Down Expand Up @@ -40,10 +31,10 @@ describe( 'makeFamiliesFromFaces', () => {
{ fontFamily: 'Duper Super', file: { name: 'piazzolla.ttf' } },
];

const error = getError( () => makeFamiliesFromFaces( fontFaces ) );
expect( error ).toHaveProperty(
'message',
'You may only batch upload fonts from the same font family.'
expect( () => makeFamiliesFromFaces( fontFaces ) ).toThrow(
new Error(
'You may only batch upload fonts from the same font family.'
)
);
} );

Expand Down