Skip to content

Fix/55278 standardize font library rest api #55454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbking wants to merge 19 commits into from
Closed

Fix/55278 standardize font library rest api #55454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
da8196d
Refactored the consumption of the API to use singular font family data
pbking Oct 5, 2023
7ce8011
Refactored unit tests to pass with code refactor.
pbking Oct 5, 2023
1b11df3
Renamed test with .spec
pbking Oct 5, 2023
eae4e9e
Refactored test to use toThrow instead of a getError function
pbking Oct 5, 2023
bb8e518
Refactor Font Library API to transfer SINGULAR items
pbking Oct 18, 2023
23c0745
update font collection tests
pbking Oct 18, 2023
47579c7
update font collection tests
pbking Oct 18, 2023
d0a4757
Fixed font family tests
pbking Oct 18, 2023
1e0b21c
Moved Font Collection tests to wpFontCollection folder
pbking Oct 18, 2023
d27f570
Added register font collection test
pbking Oct 18, 2023
5f4c8b5
Adding Font Collections Controller Tests (WIP)
pbking Oct 18, 2023
8215568
Refactored Font Library Controller tests to Font Family Controller Tests
pbking Oct 18, 2023
cfc98f1
Fixed failing font collection tests (when ran in a suite) due to repe…
pbking Oct 18, 2023
71e3f40
Fixed failing font family deletion test
pbking Oct 18, 2023
0a60636
fixed linting errors
pbking Oct 18, 2023
329ee7d
Refactored font collections get_items to use rest_ensure_response
pbking Oct 18, 2023
9af3ae0
Renamed permission callback per request
pbking Nov 7, 2023
40db889
Refactored api parameters to be snake_case instead of camelCase
pbking Nov 8, 2023
ff6d56a
Renamed test classes to align with standards
pbking Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Renamed test classes to align with standards
  • Loading branch information
@pbking
pbking committed Nov 8, 2023
commit ff6d56a39acc81055e5855c974d03ca61037691d
49 changes: 0 additions & 49 deletions phpunit/tests/fonts/font-library/wpRestFontCollectionController/base.php
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...oller/wpRestFontCollectionsController.php → ...oller/wpRestFontCollectionsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*
* @group restapi
*/
class Tests_Fonts_WpRestFontCollectionsController extends WP_Test_REST_Controller_Testcase {
class WP_Test_REST_Font_Collections_Controller extends WP_Test_REST_Controller_Testcase {

/**
* Fonts directory (in uploads).
Expand Down
2 changes: 1 addition & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFamiliesController/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @package WordPress
* @subpackage Fonts
*/
abstract class WP_REST_Font_Families_Controller_UnitTestCase extends WP_UnitTestCase {
abstract class WP_Test_REST_Font_Families_Controller_UnitTestCase extends WP_UnitTestCase {

/**
* Fonts directory (in uploads).
Expand Down
3 changes: 1 addition & 2 deletions phpunit/tests/fonts/font-library/wpRestFontFamiliesController/createItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
*
* @covers WP_REST_Font_Families_Controller::create_item()
*/
class Tests_Fonts_WPRESTFontFamilesController_CreateItem extends WP_REST_Font_Families_Controller_UnitTestCase {

class WP_Test_REST_Font_Families_Controller_CreateItem extends WP_Test_REST_Font_Families_Controller_UnitTestCase {

/**
*
Expand Down
2 changes: 1 addition & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFamiliesController/deleteItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @covers WP_REST_Font_Families_Controller::delete_item
*/
class Tests_Fonts_WPRESTFontFamiliesController_DeleteItem extends WP_REST_Font_Families_Controller_UnitTestCase {
class WP_Test_REST_Font_Families_Controller_DeleteItem extends WP_Test_REST_Font_Families_Controller_UnitTestCase {

/**
* Install fonts to test uninstall.
Expand Down
2 changes: 1 addition & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*
* @covers WP_REST_Font_Families_Controller::get_item()
*/
class Tests_Fonts_WPRESTFontFamilesController_GetItem extends WP_REST_Font_Families_Controller_UnitTestCase {
class WP_Test_REST_Font_Families_Controller_GetItem extends WP_Test_REST_Font_Families_Controller_UnitTestCase {

/**
* Install fonts to test get item.
Expand Down
2 changes: 1 addition & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItems.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*
* @covers WP_REST_Font_Families_Controller::get_items()
*/
class Tests_Fonts_WPRESTFontFamilesController_GetItems extends WP_REST_Font_Families_Controller_UnitTestCase {
class WP_Test_REST_Font_Families_Controller_GetItems extends WP_Test_REST_Font_Families_Controller_UnitTestCase {

/**
* Install fonts to test get items.
Expand Down
2 changes: 1 addition & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFamiliesController/registerRoutes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @covers WP_REST_Font_Families_Controller::register_routes
*/
class Tests_Fonts_WPRESTFontFamiliesController_RegisterRoutes extends WP_UnitTestCase {
class WP_Test_REST_Font_Families_Controller_RegisterRoutes extends WP_UnitTestCase {

public function test_register_routes() {
$routes = rest_get_server()->get_routes();
Expand Down