Update custom data view button #56002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
jameskoster
commented
Nov 9, 2023
| } | ||
|
|
||
| .edit-site-sidebar-navigation-screen-dataviews__ellipsis-button { | ||
| display: flex; |
Contributor
Author
There was a problem hiding this comment.
cc @ciampo If you place a small button inside a DropDownMenu then .components-dropdown-menu renders at a peculiar size. Here is was 26.5px tall, in Storybook it's 27.5px. Seems like a bug to fix separately, then we can remove this style.
Contributor
There was a problem hiding this comment.
Opened #56005
to fix this at the component level, you should be able to remove the custom styles once that gets merged
|
Size Change: +20 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9e45ebe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6813706061
|
ciampo
reviewed
Nov 9, 2023
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
I know it's not the scope of this PR, but while testing I noticed that the dropdown menu's toggle is rendered as a child of another button. Having a button nested inside another button is not valid HTML, since interactive elements shouldn't have other interactive elements as their content.
I suggest we refactor slightly this part of the UI so that the dropdown menu toggle sits on the side of the custom view button
| } | ||
|
|
||
| .edit-site-sidebar-navigation-screen-dataviews__ellipsis-button { | ||
| display: flex; |
Contributor
There was a problem hiding this comment.
Opened #56005
to fix this at the component level, you should be able to remove the custom styles once that gets merged
Contributor
Author
|
Closing in favor of #56005 |
Contributor
|
Just noting that, if you wanted to update the dropdown menu button to have |
Contributor
Author
|
True, but it seems the design has already changed a bit so I'll probably open a new PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the custom data view button to ensure the footprint matches regular data view buttons.
How?
Use the
smallButton variant.Testing Instructions
Before
Note the custom data view button is much taller due to the regular size ellipsis button.
After