Skip to content

Update custom data view button #56002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jameskoster wants to merge 1 commit into from
Closed

Update custom data view button #56002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/edit-site/src/components/sidebar-dataviews/custom-dataviews-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ function CustomDataViewItem( { dataviewId, isActive } ) {
icon={ moreVertical }
label={ __( 'Actions' ) }
toggleProps={ {
size: 'small',
className: 'edit-site-sidebar-navigation-screen-dataviews__ellipsis-button',
style: {
color: 'inherit',
},
Expand Down
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/sidebar-dataviews/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,7 @@
text-transform: uppercase;
}
}

.edit-site-sidebar-navigation-screen-dataviews__ellipsis-button {
display: flex;
Copy link
Contributor Author

@jameskoster jameskoster Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ciampo If you place a small button inside a DropDownMenu then .components-dropdown-menu renders at a peculiar size. Here is was 26.5px tall, in Storybook it's 27.5px. Seems like a bug to fix separately, then we can remove this style.

Copy link
Contributor

@ciampo ciampo Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #56005
to fix this at the component level, you should be able to remove the custom styles once that gets merged

Copy link
Contributor

@ciampo ciampo Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New attempt in #56136

}