Skip to content

BoxControl: update design #56665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brookewp merged 37 commits into from
Jan 12, 2024
Merged

BoxControl: update design #56665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
910badb
Change to vertical formatting without width constraints
brookewp Nov 29, 2023
bdf1157
Add RangeControl to input controls
brookewp Nov 29, 2023
5eb20cc
Only show Icon for AllInputControl
brookewp Nov 29, 2023
e3c63de
Add RangeControl to AllInputControl
brookewp Nov 30, 2023
5dcef43
Clean up styles and match SpacingInputControl
brookewp Dec 1, 2023
695bba7
Add changes to InputControls to AxialInputControls
brookewp Dec 2, 2023
c0a8d7f
Update styles based on design input
brookewp Dec 2, 2023
6b78cf1
Fix issue where changing input didn’t affect rangecontrol
brookewp Dec 2, 2023
94db809
Add labels to sliders
brookewp Dec 2, 2023
ac87f8e
Add unit tests for slider
brookewp Dec 2, 2023
c9ac4b5
Update changelog
brookewp Dec 2, 2023
6076058
Update function name and add limitations to slider based on units
brookewp Dec 8, 2023
11b46d6
Add right margin to prevent slider thumb from being cut off
brookewp Dec 8, 2023
8fa41ab
Update slider’s initial position to check for a value
brookewp Dec 11, 2023
f1c9be2
Replace Tooltip with component
brookewp Dec 12, 2023
ec4985c
Use Grid for better semantics and a11y
brookewp Dec 12, 2023
a9ae993
Add id for slider aria labels
brookewp Dec 12, 2023
2494cdb
Implement changes from PR feedback
brookewp Dec 14, 2023
0a041fc
Adjust grid
brookewp Dec 14, 2023
8dc9b1c
Update column sizing
brookewp Dec 14, 2023
a57f3e2
Fix value by using `allValue` again
brookewp Dec 14, 2023
b28c652
Refactor to remove duplicate onChange based on feedback
brookewp Dec 14, 2023
7fbbe43
Fix mapped ids
brookewp Dec 15, 2023
73b65eb
Update naming based on feedback
brookewp Jan 3, 2024
f2bdae4
Fix id and key
brookewp Jan 3, 2024
7cdab78
Remove unused border radius logic
brookewp Jan 3, 2024
187ae8a
Update margin to include RTL
brookewp Jan 3, 2024
9121904
Remove unused hover functions for previously replaced visualizer
brookewp Jan 3, 2024
b5f546e
Replace custom UnitControl with standard
brookewp Jan 3, 2024
6287be9
Fix all input label
brookewp Jan 3, 2024
25cf3f6
Update naming in tests
brookewp Jan 8, 2024
3f9ec19
Add mixed label and test
brookewp Jan 8, 2024
178ff28
Restore Mixed placeholder
brookewp Jan 9, 2024
a780070
Remove unnecessary function
brookewp Jan 9, 2024
ced9711
Update naming
brookewp Jan 9, 2024
6dc8d44
Add labels to slider
brookewp Jan 10, 2024
505ac98
Fix label in test
brookewp Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore Mixed placeholder
  • Loading branch information
@brookewp
brookewp committed Jan 9, 2024
commit 178ff28fc01c33b781b80b424fb139a9bb556405
2 changes: 1 addition & 1 deletion packages/components/src/box-control/all-input-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default function AllInputControl( {
onUnitChange={ handleOnUnitChange }
onFocus={ handleOnFocus }
placeholder={ allPlaceholder }
label={ isMixed ? LABELS.mixed : LABELS.all }
label={ LABELS.all }
hideLabelFromVision
/>

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/box-control/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const LABELS = {
bottom: __( 'Bottom side' ),
left: __( 'Left side' ),
right: __( 'Right side' ),
mixed: __( 'Mixed sides' ),
mixed: __( 'Mixed' ),
vertical: __( 'Top and bottom sides' ),
horizontal: __( 'Left and right sides' ),
};
Expand Down