-
Notifications
You must be signed in to change notification settings - Fork 4.7k
BoxControl: update design
#56665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BoxControl: update design
#56665
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
910badb
Change to vertical formatting without width constraints
brookewp bdf1157
Add RangeControl to input controls
brookewp 5eb20cc
Only show Icon for AllInputControl
brookewp e3c63de
Add RangeControl to AllInputControl
brookewp 5dcef43
Clean up styles and match SpacingInputControl
brookewp 695bba7
Add changes to InputControls to AxialInputControls
brookewp c0a8d7f
Update styles based on design input
brookewp 6b78cf1
Fix issue where changing input didn’t affect rangecontrol
brookewp 94db809
Add labels to sliders
brookewp ac87f8e
Add unit tests for slider
brookewp c9ac4b5
Update changelog
brookewp 6076058
Update function name and add limitations to slider based on units
brookewp 11b46d6
Add right margin to prevent slider thumb from being cut off
brookewp 8fa41ab
Update slider’s initial position to check for a value
brookewp f1c9be2
Replace Tooltip with component
brookewp ec4985c
Use Grid for better semantics and a11y
brookewp a9ae993
Add id for slider aria labels
brookewp 2494cdb
Implement changes from PR feedback
brookewp 0a041fc
Adjust grid
brookewp 8dc9b1c
Update column sizing
brookewp a57f3e2
Fix value by using `allValue` again
brookewp b28c652
Refactor to remove duplicate onChange based on feedback
brookewp 7fbbe43
Fix mapped ids
brookewp 73b65eb
Update naming based on feedback
brookewp f2bdae4
Fix id and key
brookewp 7cdab78
Remove unused border radius logic
brookewp 187ae8a
Update margin to include RTL
brookewp 9121904
Remove unused hover functions for previously replaced visualizer
brookewp b5f546e
Replace custom UnitControl with standard
brookewp 6287be9
Fix all input label
brookewp 25cf3f6
Update naming in tests
brookewp 3f9ec19
Add mixed label and test
brookewp 178ff28
Restore Mixed placeholder
brookewp a780070
Remove unnecessary function
brookewp ced9711
Update naming
brookewp 6dc8d44
Add labels to slider
brookewp 505ac98
Fix label in test
brookewp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update naming
- Loading branch information
commit ced9711fefa3725d1ba6b9265d2f8b0d5883c7e9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.