Skip to content

Block editor: remove 4 useSelect in favour of context #56915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 6 commits into from
Dec 11, 2023
Merged

Block editor: remove 4 useSelect in favour of context #56915

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8ce3bb
Block editor: remove 4 useSelect in favour of context
ellatrix Dec 8, 2023
4f018f6
Fix unit tests
ellatrix Dec 9, 2023
aab8f1a
Fix mobile
ellatrix Dec 10, 2023
952096b
Fix typo
ellatrix Dec 10, 2023
69c9d34
Make private with symbol
ellatrix Dec 10, 2023
e0da783
Add comment on use of Symbol
ellatrix Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit tests
  • Loading branch information
@ellatrix
ellatrix committed Dec 10, 2023
commit 4f018f6a1c35aa9c7a74534287930ab0e1dab0e3
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/block-controls/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe( 'BlockControls', () => {
it( 'should render a dynamic toolbar of controls', () => {
render(
<SlotFillProvider>
<BlockEdit name="core/test-block" isSelected>
<BlockEdit name="core/test-block" mayDisplayControls>
<BlockControls controls={ controls }>
<p>Child</p>
</BlockControls>
Expand All @@ -84,7 +84,7 @@ describe( 'BlockControls', () => {
it( 'should render its children', () => {
render(
<SlotFillProvider>
<BlockEdit name="core/test-block" isSelected>
<BlockEdit name="core/test-block" mayDisplayControls>
<BlockControls controls={ controls }>
<p>Child</p>
</BlockControls>
Expand All @@ -99,7 +99,7 @@ describe( 'BlockControls', () => {
it( 'should a dynamic toolbar when passed as children', () => {
render(
<SlotFillProvider>
<BlockEdit name="core/test-block" isSelected>
<BlockEdit name="core/test-block" mayDisplayControls>
<BlockControls>
<ToolbarGroup controls={ controls } />
</BlockControls>
Expand Down