Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting
  • Loading branch information
ramonjd committed Feb 10, 2024
commit 332bc868f2f2657a1103a5481721d66050d5e81d
2 changes: 1 addition & 1 deletion packages/style-engine/class-wp-style-engine-processor.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function add_rules( $css_rules ) {

foreach ( $css_rules as $rule ) {
// Check for rules that need to be nested in containers.
$selector = $rule->get_selector();
$selector = $rule->get_selector();

if ( empty( $selector ) ) {
continue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ public function test_should_instantiate_with_selector_and_rules() {
*/
public function test_should_only_add_rule_objects() {
$css_container = new WP_Style_Engine_CSS_Rules_Container_Gutenberg( '@media not all and (hover: hover)' );
$selector = '.goanna';
$css_rule_1 = new WP_Style_Engine_CSS_Rule_Gutenberg(
$selector,
array(
'font-size' => '2rem',
)
);

$css_container->add_rules( '' );
$this->assertSame( array(), $css_container->get_rules(), 'Return value of get_rules() does not match expected rules.' );
$this->assertSame( array(), $css_container->get_rules(), 'Return value of get_rules() does not match expected rules when empty string added.' );

$css_container->add_rules( array() );
$this->assertSame( array(), $css_container->get_rules(), 'Return value of get_rules() does not match expected rules when array() added.' );

$css_container->add_rules( new WP_Style_Engine_CSS_Rules_Container_Gutenberg( '@media not all and (hover: hover)' ) );
$this->assertSame( array(), $css_container->get_rules(), 'Return value of get_rules() does not match expected rules when unknown class added.' );
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,17 @@ public function test_should_add_rule_object_to_existing_store() {
$new_hotdog_store = WP_Style_Engine_CSS_Rules_Store_Gutenberg::get_store( 'hotdog' );

$selector = '.pickle';
$pickle_rule = new WP_Style_Engine_CSS_Rule_Gutenberg( $selector, array(
'color' => 'brown',
'border-color' => 'yellow',
'border-radius' => '10rem',
) );
$pickle_rule = new WP_Style_Engine_CSS_Rule_Gutenberg(
$selector,
array(
'color' => 'brown',
'border-color' => 'yellow',
'border-radius' => '10rem',
)
);
$pickle_container = new WP_Style_Engine_CSS_Rules_Container_Gutenberg( '.hotdog', $pickle_rule );
$added_rule = $new_hotdog_store->add_rule( $pickle_container );
$expected = ".hotdog{.pickle{color:brown;border-color:yellow;border-radius:10rem;}}";
$expected = '.hotdog{.pickle{color:brown;border-color:yellow;border-radius:10rem;}}';

$this->assertSame( $expected, $added_rule->get_css(), 'Return value of store rule get_css() matches passed rule object get_css().' );
}
Expand Down