-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Style engine: support nested CSS rules (or CSS containers) #58797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4d77e49
First commit
ramonjd 17afecc
Tests
ramonjd 794d4d9
Extracting file
ramonjd 5bea1a6
Refactor output public API methods in style-engine
ramonjd 08211cc
Store containers in the store. No need to store container names on th…
ramonjd cafcbc6
Revert changes to WP_Style_Engine_CSS_Rule
ramonjd 63ef366
Formatting
ramonjd 0514b53
Added container tests
ramonjd 332bc86
linting
ramonjd 63b29de
Added empty test
ramonjd e6be2cc
Format
ramonjd 66063d3
Adding more test examples for wp_engine_get_stylesheet_from_css_rules
ramonjd 081de82
Remove TODOs
ramonjd 5276e36
Remove unused properties of container class
ramonjd eb5797c
Lint me
ramonjd 4dcdc8b
Some notes
ramonjd b10ef34
linty
ramonjd 1737f72
Tidy up store and add tests
ramonjd 84f0f4c
Test for nesting other at-rules
ramonjd e69c10d
Remove comments
ramonjd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added empty test
- Loading branch information
commit 63b29de4626fc368888112834a3fa6e50e226335
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to unit test this using
$this->expectNotice();