Skip to content

Fix Global Styles controller incompatible with extended Core classes #58972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 4 commits into from
Closed

Fix Global Styles controller incompatible with extended Core classes #58972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98f71c0
Pass parent post type as per extended class constructor
getdave Feb 13, 2024
5b44728
Define parent post type property to align with extended classes
getdave Feb 13, 2024
31adb2c
Set property on 6.4 class
getdave Feb 13, 2024
5773a8c
Simplify
getdave Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/compat/wordpress-6.4/class-gutenberg-rest-global-styles-revisions-controller-6-4.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
* @see WP_REST_Controller
*/
class Gutenberg_REST_Global_Styles_Revisions_Controller_6_4 extends WP_REST_Global_Styles_Revisions_Controller {


protected $parent_post_type;

/**
* Prepares the revision for the REST response.
*
Expand Down
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.5/rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* Registers the Global Styles Revisions REST API routes.
*/
function gutenberg_register_global_styles_revisions_endpoints() {
$global_styles_revisions_controller = new Gutenberg_REST_Global_Styles_Revisions_Controller_6_5();
$global_styles_revisions_controller = new Gutenberg_REST_Global_Styles_Revisions_Controller_6_5( 'wp_global_styles' );
$global_styles_revisions_controller->register_routes();
}

Expand Down