Fix Global Styles controller incompatible with extended Core classes

[getdave]

What?

Fatal error: Uncaught ArgumentCountError: Too few arguments to function WP_REST_Global_Styles_Revisions_Controller::__construct(), 0

This is because the 6.5 class didn't pass the parent post type argument and the 6.4 class didn't define the property.

See https://wordpress.slack.com/archives/C02RQBWTW/p1707834984621719.

Why?

How?

Testing Instructions

• run latest wordpress trunk.
• check out Gutenberg trunk.
• visit Site Editor
• see errors
• apply this PR
• don't see errors

Note that it's possible WP Core trunk will have patched this already.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/class-gutenberg-rest-global-styles-revisions-controller-6-4.php
❔ lib/compat/wordpress-6.5/rest-api.php

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jonnynews.

Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[getdave]

We might end up patching this in Core WordPress/wordpress-develop#6106

[jonnynews]

@getdave I think this should be fixed in core. This fix works in core WordPress/wordpress-develop@95db1e9

[getdave]

That fix now looks to have been committed so I can close this one out as not required.

[jonnynews]

That fix now looks to have been committed so I can close this one out as not required.

It was not committed. The global controller was reverted. That commit is from a PR.

[getdave]

PR referenced above