-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Block JSON schema: Add viewScriptModule field
#59060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 12ee830. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7913243044
|
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I need to test if we are supporting arrays at this moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! From what I've researched, it appears to support arrays.
- Document: https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/block-api/block-metadata.md#view-script-module
- PHPUnit test: https://github.com/WordPress/wordpress-develop/blob/7b24083859c37d8ac75b9549f458bc389610eaef/tests/phpunit/data/blocks/notice/block.json#L71
cbravobernal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This is great. Thank you for extending the |
|
Thanks for handling this! |
Related to #58203
What?
This PR adds a
viewScriptModulefield to the schema ofblock.json.Why?
To enhance the developer experience. My understanding is that
viewScriptModuleis now officially published instead ofviewModule.Testing Instructions
Create a JSON file like the one below and open it in a code editor.
{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/schema/block-json-view-script-module/schemas/json/block.json", "name": "test/test", "title": "Test" }You should see
viewScriptModulereference.Screenshots or screencast