Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
There are some test failures, but they don't seem to be the result of this PR. In fact, there are some test failures in the HEAD of the wp/6.5 branch. |
|
Let’s give it a try. Thank you for crafting these changes. It looks like CI is failing also because of reports related to outdated config for browserlist. This is something that probably should be disabled on old branches. Can we close the issue now? |
|
Thanks for the review! Yes, #62780 can be closed. |
Note
This PR is not for the
trunkbranch. It is for fixing a block.json schema issue in the WP 6.5 branch.What?
This PR is to fix missing fields, inconsistencies, etc. in block.json schema in WP6.5.
How?
I looked at the diff between the two branches,
wp/6.5andWP/6.6(see this comment) and added missing fields and fixed existing fields.The fields that were changed, why they were changed, and the associated PR are below.
supports.color.heading,supports.color.button: Fix description grammarsupports.background: Add missing fieldssupports.layout.allowCustomContentAndWideSize: Add missing fieldslayout.allowCustomContentAndWideSizefield #59736supports.shadow: Adding default value and descriptionshadowdefinition #58910supports.interactivity: The location is incorrectblock supportsforclientNavigationandinteractiveproperties onblock.jsonschema. #58132viewScriptModule: Add missing fieldsviewScriptModulefield #59060Testing Instructions
Create a JSON file like the one below:
{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/wp/6.5-fix-block-json-schema/schemas/json/block.json" }The code editor should now correctly display the changes made in this PR.
Screenshots or screencast