Changed installFont to installFonts so that multiple font families can be installed at once #59451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…n be installed at once
pbking
force-pushed
the
fix/upload-multiple-font-families
branch
from
aa6843b to
3b30695
Compare
|
Size Change: +87 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
mikachan
added
[Type] Bug
mikachan
reviewed
Feb 29, 2024
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
I've just tested this by trying to install two fonts from two different font families (Commissioner and Noto Serif). The fonts are installed but neither are activated:
Looks like they're successfully passed to activateCustomFontFamilies but setFontFamilies isn't working as expected.
|
|
||
| try { | ||
| await installFont( fontFamily ); | ||
| await installFonts( [ fontFamily ] ); |
Member
There was a problem hiding this comment.
Suggested change
| await installFonts( [ fontFamily ] ); | |
| await installFonts( fontFamily ); |
Only a small nitpick but I think I'd rather the installFonts function handled converting arguments to an array (e.g. checking if fontFamiliesToInstall is an array, if not then converting it), as I think it would slightly improve the readability here.
Contributor
Author
There was a problem hiding this comment.
I'm generally opposed to passing different types of arguments into a function. If we need to change how that value is passed to offer clarity I would rather do that (i.e. fontFamiliesToInstall = []; fontFamiliesToInstall.push( fontFamily ); installFonts( fontFamiliesToInstall );
Member
There was a problem hiding this comment.
Yeah I think that's a good alternative too 👍
Contributor
Author
This was what I spent 90% of the time working on for this feature. :/ I thought I had it lined up but I'll take another look. |
Contributor
Author
|
Made a silly async error (and an even sillier length check). The result was that it worked fine when I had breakpoints. :P Less so otherwise. It is fixed now. Another look would be appreciate. :) |
mikachan
approved these changes
Feb 29, 2024
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
Made a silly async error (and an even sillier length check). The result was that it worked fine when I had breakpoints. :P Less so otherwise.
The length check confused me when I was debugging 😆
This is working great for me now 🎉
pbking
added
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…n be installed at once (#59451) * Changed installFont to installFonts so that multiple font families can be installed at once --------- Co-authored-by: pbking <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: provenself <[email protected]> Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: peterwilsoncc <[email protected]>
Contributor
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 122d14c |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…n be installed at once (#59451) * Changed installFont to installFonts so that multiple font families can be installed at once --------- Co-authored-by: pbking <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: provenself <[email protected]> Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: peterwilsoncc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor installation logic to not just install multiple font faces at once, but multiple font families.
This is done so that any combination of font faces can be dropped onto the upload panel to install then all-at-once.
Why?
Fixes: #58689
Fixes: #59138
How?
Refactor installFont to support a collection of fontFamiles, all of which will be installed in a single user action
Testing Instructions
Use the upload panel to upload font faces from different font families in a single action.
All of those font faces should be installed.
Testing Instructions for Keyboard
Screenshots or screencast