Update Typescript to 5.4.5 #60793
Update Typescript to 5.4.5 #60793
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsnajdr
left a comment
jsnajdr
left a comment
There was a problem hiding this comment.
Yes, this looks good 👍 I just tried to upgrade TS locally and arrived at exactly the same changes.
| "incremental": false, | ||
| "composite": false, | ||
| "module": "CommonJS", | ||
| "module": "Node16", |
There was a problem hiding this comment.
This needs to be done to fix an error:
error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
I'm not really sure what exactly this does. The matching moduleResolution: node16 field was added by @swissspidy in https://github.com/WordPress/gutenberg/pull/52993/files#r1288451752
2 participants
What?
Update Typescript to 5.4.5
Testing Instructions
npm run buildlocally