Skip to content

Update Typescript to 5.4.5 #60793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 3 commits into from
Apr 19, 2024
Merged

Update Typescript to 5.4.5 #60793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db59ae
Update typescript dependency to 5.4.5
simonhammes Apr 16, 2024
bdaf0dd
Update dependencies to fix TSC errors
simonhammes Apr 16, 2024
5f3e71b
Fix TS5110 error
simonhammes Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 21 additions & 33 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@
"@testing-library/react": "14.0.0",
"@testing-library/react-native": "12.4.3",
"@testing-library/user-event": "14.4.3",
"@types/eslint": "7.28.0",
"@types/estree": "0.0.50",
"@types/eslint": "8.56.9",
"@types/estree": "1.0.5",
"@types/istanbul-lib-report": "3.0.0",
"@types/mime": "2.0.3",
"@types/npm-package-arg": "6.1.1",
Expand Down Expand Up @@ -254,7 +254,7 @@
"strip-json-comments": "5.0.0",
"style-loader": "3.2.1",
"terser-webpack-plugin": "5.3.9",
"typescript": "5.1.6",
"typescript": "5.4.5",
"uglify-js": "3.13.7",
"uuid": "9.0.1",
"webdriverio": "8.16.20",
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-test-utils-playwright/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"compilerOptions": {
"incremental": false,
"composite": false,
"module": "CommonJS",
"module": "Node16",
Copy link
Member

@jsnajdr jsnajdr Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done to fix an error:

error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.

I'm not really sure what exactly this does. The matching moduleResolution: node16 field was added by @swissspidy in https://github.com/WordPress/gutenberg/pull/52993/files#r1288451752

"moduleResolution": "node16",
"types": [ "node" ],
"rootDir": "src",
Expand Down