Fix: Button: Replace remaining 40px default size violation [Edit Site 1] #65226
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you go to site editor and go to template, add new and select any template.
Note: This would have no impact as it has some styles which are overriden.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you go to site editor and go to template, add new and check the modal for the same.
Note: This would have no impact as it has some styles which are overridden.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you go to site editor --> styles --> revisions, there is close button.
| Before | After |
|---|---|
 |
 |
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This can be seen when you go to site editor --> styles, check for the left top icon to go back to dashboard or other page.
Note: This does not have impact because of some overridden styles.
| Before | After |
|---|---|
 |
 |
| variant="secondary" | ||
| ref={ ref } | ||
| > | ||
| <Button __next40pxDefaultSize variant="secondary" ref={ ref }> |
There was a problem hiding this comment.
This can be seen when you have some unexpected error on editor and it breaks.
Note: It has some overridden style as height auto, so overall button size would get increased.
| Before | After |
|---|---|
 |
 |
noisysocks
added
the
Backport to WP 6.9 Beta/RC
… 1] (#65226) * Fix custom template modal button suggestion list to use default 40px button height * Fix the add new template modal item button to use 40px default size * Fix editor canvas close button to use 40px default button size * Fix add the editor index back button for edit site to use 40px default size * Fix the copy error button size for error boundry warning to use 40px default size Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]>
noisysocks
added
Backported to WP Core
4 participants
Part of - #65018
What?
Why?
How?
__next40pxDefaultSize={ false }to__next40pxDefaultSizeon component.Testing Instructions