Skip to content

Fix: Button: Replace remaining 40px default size violation [Edit Site 1] #65226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 5 commits into from
Sep 19, 2024
Merged

Fix: Button: Replace remaining 40px default size violation [Edit Site 1] #65226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fde025
Fix custom template modal button suggestion list to use default 40px …
hbhalodia Sep 11, 2024
615a116
Fix the add new template modal item button to use 40px default size
hbhalodia Sep 11, 2024
8408756
Fix editor canvas close button to use 40px default button size
hbhalodia Sep 11, 2024
50a56de
Fix add the editor index back button for edit site to use 40px defaul…
hbhalodia Sep 11, 2024
1d48ebb
Fix the copy error button size for error boundry warning to use 40px …
hbhalodia Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/edit-site/src/components/add-new-template/add-custom-template-modal-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ function SuggestionListItem( {
<Composite.Item
render={
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you go to site editor and go to template, add new and select any template.

Note: This would have no impact as it has some styles which are overriden.

Before After
custom-template-before custom-template-after

role="option"
className={ baseCssClass }
onClick={ () =>
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-site/src/components/add-new-template/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ function TemplateListItem( {
} ) {
return (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you go to site editor and go to template, add new and check the modal for the same.

Note: This would have no impact as it has some styles which are overridden.

Before After
custom-template-index-before Custom-template-index-after

className={ className }
onClick={ onClick }
label={ description }
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-site/src/components/editor-canvas-container/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ function EditorCanvasContainer( {
>
{ shouldShowCloseButton && (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you go to site editor --> styles --> revisions, there is close button.

Before After
editor-canvas-close-before Editor-anvas-close-after

className="edit-site-editor-canvas-container__close-button"
icon={ closeSmall }
label={ closeButtonLabel || __( 'Close' ) }
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-site/src/components/editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,7 @@ export default function EditSiteEditor( { isPostsList = false } ) {
whileTap="tap"
>
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you go to site editor --> styles, check for the left top icon to go back to dashboard or other page.

Note: This does not have impact because of some overridden styles.

Before After
Editor-close-button-before Editor-close-button-after

label={ __( 'Open Navigation' ) }
showTooltip
tooltipPosition="middle right"
Expand Down
7 changes: 1 addition & 6 deletions packages/edit-site/src/components/error-boundary/warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ import { useCopyToClipboard } from '@wordpress/compose';
function CopyButton( { text, children } ) {
const ref = useCopyToClipboard( text );
return (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
variant="secondary"
ref={ ref }
>
<Button __next40pxDefaultSize variant="secondary" ref={ ref }>
Copy link
Contributor Author

@hbhalodia hbhalodia Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be seen when you have some unexpected error on editor and it breaks.

Note: It has some overridden style as height auto, so overall button size would get increased.

Before After
error-boundry-before error-boundry-after

{ children }
</Button>
);
Expand Down