Skip to content

Block support: Preserve anchor value in comment delimiter #70993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 11 commits into from
Dec 16, 2025
Merged

Block support: Preserve anchor value in comment delimiter #70993

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3c3cae
Block support: Preserve anchor value in comment delimiter
t-hamano Jul 31, 2025
f3ca9ea
Fix some unit tests
t-hamano Jul 31, 2025
ff9b63a
Fix one unit test
t-hamano Jul 31, 2025
047167c
Don't save falsy value
t-hamano Jul 31, 2025
9e9985c
Don't preserve empty anchor when transforming from Spacer block to Se…
t-hamano Jul 31, 2025
5cca67b
Don't preserve empty anchor when transforming from Separator block to…
t-hamano Jul 31, 2025
c96f0ee
Try to fix mobile unit test
t-hamano Jul 31, 2025
862a7ea
Merge branch 'trunk' into update-anchor-support
t-hamano Sep 12, 2025
fb80a2d
Regenerate fixtures
t-hamano Sep 12, 2025
f441b07
Merge branch 'trunk' into update-anchor-support
t-hamano Oct 13, 2025
ab91b70
Merge branch 'trunk' into update-anchor-support
t-hamano Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try to fix mobile unit test
  • Loading branch information
@t-hamano
t-hamano committed Jul 31, 2025
commit c96f0ee94990502d4c5b10f4f23ea48c3f7502fe
2 changes: 1 addition & 1 deletion packages/block-library/src/list/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function createListBlockFromDOMElement( listElement ) {
const type = listElement.getAttribute( 'type' );
const listAttributes = {
ordered: 'OL' === listElement.tagName,
anchor: listElement.id === '' ? undefined : listElement.id,
anchor: listElement.id ? listElement.id : undefined,
Copy link
Contributor Author

@t-hamano t-hamano Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without making this change, the mobile unit tests will fail. See: http://github.com/WordPress/gutenberg/actions/runs/16643294936/job/47097872501

start: listElement.getAttribute( 'start' )
? parseInt( listElement.getAttribute( 'start' ), 10 )
: undefined,
Expand Down
Loading